Stream: git-cranelift

Topic: cranelift / PR #1360 Address nits from #1325

view this post on Zulip GitHub (Jan 22 2020 at 17:20):

bnjbvr opened PR #1360 from 1325-nits to master:

Addresses the nits from #1325. Note we can't check for the presence of split in the output after legalization, because the machinery is able to reuse a pair (previously created by a concat). It is just that now the test passes, while it was panicking before #1325. I reduced the testing scope by making it a legalizer test, and reflecting this by moving the file to a different directory.

r? @eqrion

view this post on Zulip GitHub (Jan 22 2020 at 22:16):

eqrion submitted PR Review.

view this post on Zulip GitHub (Jan 23 2020 at 08:39):

bnjbvr merged PR #1360.

Last updated: Nov 22 2024 at 16:03 UTC