Stream: git-cranelift

Topic: cranelift / PR #1351 Add initial Cranelift interpreter fu...

GitHub (Jan 15 2020 at 17:50):

abrown opened PR #1351 from upstream-interpreter to master:

• [x] This has been discussed in meetings and chat messages.
• [x] A short description of what this does, why it is needed: this implements a rudimentary interpreter for Cranelift IR; only a subset of instructions are currently implemented and implementation gaps are marked with TODO or FIXME. This PR is a RFC on the interpreter design; any feedback is welcome.
• [x] This PR contains test cases, if meaningful.
• [s] A reviewer from the core maintainer team has been assigned for this PR.

GitHub (Jan 15 2020 at 17:50):

abrown requested bnjbvr for a review on PR #1351.

GitHub (Jan 15 2020 at 17:50):

abrown requested bnjbvr, and julian-seward1 for a review on PR #1351.

GitHub (Jan 15 2020 at 17:50):

abrown requested bnjbvr, sunfishcode, and julian-seward1 for a review on PR #1351.

GitHub (Jan 15 2020 at 17:51):

abrown edited PR #1351 from upstream-interpreter to master:

• [x] This has been discussed in meetings and chat messages.
• [x] A short description of what this does, why it is needed: this implements a rudimentary interpreter for Cranelift IR; only a subset of instructions are currently implemented and implementation gaps are marked with TODO or FIXME. This PR is a RFC on the interpreter design; any feedback is welcome.
• [x] This PR contains test cases, if meaningful.
• [x] A reviewer from the core maintainer team has been assigned for this PR.

GitHub (Jan 15 2020 at 18:03):

bjorn3 submitted PR Review.

GitHub (Jan 15 2020 at 18:03):

bjorn3 created PR Review Comment:

What does TCO mean in this context?

GitHub (Jan 15 2020 at 18:03):

bjorn3 submitted PR Review.

GitHub (Jan 15 2020 at 18:03):

bjorn3 created PR Review Comment:

This README should be changed to describe the interpreter instead of the module system.

GitHub (Jan 15 2020 at 18:03):

bjorn3 created PR Review Comment:

What is the purpose of this?

GitHub (Jan 15 2020 at 18:03):

bjorn3 created PR Review Comment:

I think this should be u64 instead. In any case it is important to not forget correct zero/sign extension.

GitHub (Jan 15 2020 at 18:03):

bjorn3 created PR Review Comment:

I am afraid this won't be removed when it isn't WIP anymore.

GitHub (Jan 15 2020 at 18:04):

abrown submitted PR Review.

GitHub (Jan 15 2020 at 18:04):

abrown created PR Review Comment:

tail-call optimization

GitHub (Jan 15 2020 at 18:05):

abrown submitted PR Review.

GitHub (Jan 15 2020 at 18:05):

abrown created PR Review Comment:

IDE hint; will remove

GitHub (Jan 15 2020 at 18:10):

abrown updated PR #1351 from upstream-interpreter to master:

• [x] This has been discussed in meetings and chat messages.
• [x] A short description of what this does, why it is needed: this implements a rudimentary interpreter for Cranelift IR; only a subset of instructions are currently implemented and implementation gaps are marked with TODO or FIXME. This PR is a RFC on the interpreter design; any feedback is welcome.
• [x] This PR contains test cases, if meaningful.
• [x] A reviewer from the core maintainer team has been assigned for this PR.

GitHub (Jan 15 2020 at 18:11):

abrown submitted PR Review.

GitHub (Jan 15 2020 at 18:11):

abrown created PR Review Comment:

You're probably right; let me think some more about this.

GitHub (Jan 22 2020 at 04:16):

abrown updated PR #1351 from upstream-interpreter to master:

• [x] This has been discussed in meetings and chat messages.
• [x] A short description of what this does, why it is needed: this implements a rudimentary interpreter for Cranelift IR; only a subset of instructions are currently implemented and implementation gaps are marked with TODO or FIXME. This PR is a RFC on the interpreter design; any feedback is welcome.
• [x] This PR contains test cases, if meaningful.
• [x] A reviewer from the core maintainer team has been assigned for this PR.

GitHub (Jan 22 2020 at 17:47):

abrown created PR Review Comment:

Is this better as a FuncRef? I used &'a Function here because it was convenient but it may be more consistent and (possibly?) efficient to use a 4-byte FuncRef here instead. (I probably need to look again at how efficient it is to use FuncRef to index into an Environment).

GitHub (Jan 22 2020 at 17:47):

abrown submitted PR Review.

GitHub (Mar 04 2020 at 14:41):

bnjbvr closed without merge PR #1351.

Last updated: Nov 26 2024 at 01:30 UTC