Stream: git-cranelift

Topic: cranelift / PR #1343 Fix narrow_icmp_imm

GitHub (Jan 14 2020 at 12:26):

jmkrauz opened PR #1343 from legalization to master:

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.
  This is a really small change.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.
  This fixes small bug caused by inaccurate use of parentheses in narrow_icmp_imm.

• [ ] This PR contains test cases, if meaningful.
  No tests.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so and/or ping
  bnjbvr. The list of suggested reviewers on the right can help you.
  @bnjbvr
  <!-- Please ensure all communication adheres to the code of conduct. -->

GitHub (Jan 20 2020 at 17:22):

bnjbvr submitted PR Review.

GitHub (Jan 21 2020 at 11:23):

jmkrauz updated PR #1343 from legalization to master:

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.
  This is a really small change.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.
  This fixes small bug caused by inaccurate use of parentheses in narrow_icmp_imm.

• [ ] This PR contains test cases, if meaningful.
  No tests.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so and/or ping
  bnjbvr. The list of suggested reviewers on the right can help you.
  @bnjbvr
  <!-- Please ensure all communication adheres to the code of conduct. -->

GitHub (Jan 21 2020 at 11:44):

jmkrauz requested bnjbvr for a review on PR #1343.

GitHub (Jan 21 2020 at 14:20):

bnjbvr submitted PR Review.

GitHub (Jan 21 2020 at 14:20):

bnjbvr merged PR #1343.

Last updated: Oct 23 2024 at 20:03 UTC