Stream: git-cranelift

Topic: cranelift / PR #1337 Correctly count the number of wasm p...

GitHub (Jan 11 2020 at 00:25):

sunfishcode requested bnjbvr for a review on PR #1337.

GitHub (Jan 11 2020 at 00:25):

sunfishcode opened PR #1337 from is-wasm-parameter to master:

Following up on #1329, this further replaces num_normal_params with a function
which calls is_wasm_parameter to correctly count the number of wasm
parameters a function has.

• [X] This has been discussed in issue #1329.
• [X] See the commit message above.
• [X] No user-visible behavior, and we'll mainly test this in wasmtime.
• [X] A reviewer from the core maintainer team has been assigned for this PR.

<!-- Please ensure all communication adheres to the code of conduct. -->

GitHub (Jan 13 2020 at 10:01):

bnjbvr submitted PR Review.

GitHub (Jan 13 2020 at 10:01):

bnjbvr created PR Review Comment:

I also realized it would be nicer for embedders that this implementation be the default impl in FuncEnvironment (eg I doubt spidermonkey will require special behavior here). Can you move the code there, please?

GitHub (Jan 13 2020 at 10:01):

bnjbvr submitted PR Review.

GitHub (Jan 14 2020 at 18:56):

sunfishcode updated PR #1337 from is-wasm-parameter to master:

Following up on #1329, this further replaces num_normal_params with a function
which calls is_wasm_parameter to correctly count the number of wasm
parameters a function has.

• [X] This has been discussed in issue #1329.
• [X] See the commit message above.
• [X] No user-visible behavior, and we'll mainly test this in wasmtime.
• [X] A reviewer from the core maintainer team has been assigned for this PR.

<!-- Please ensure all communication adheres to the code of conduct. -->

GitHub (Jan 14 2020 at 19:09):

sunfishcode created PR Review Comment:

Done!

GitHub (Jan 14 2020 at 19:09):

sunfishcode submitted PR Review.

GitHub (Jan 14 2020 at 19:42):

sunfishcode merged PR #1337.

Last updated: Dec 23 2024 at 13:07 UTC