GitHub (Jan 10 2020 at 00:54): GitHub (Jan 10 2020 at 00:54):sunfishcode requested bnjbvr for a review on PR #1329.
GitHub (Jan 10 2020 at 00:54):sunfishcode opened PR #1329 from is-wasm-parameter to master:
This provides a more flexible way to allow embedding to tell
cranelift-wasm which function parameters are hidden, and which should be
translated as wasm user variables.This replaces https://github.com/bytecodealliance/cranelift/pull/1086.
- [X] This has been discussed in issue #1086
[X] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[X] This PR contains test cases, if meaningful. No tests as this doesn't change any functionality.
- [X] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so and/or ping
bnjbvr. The list of suggested reviewers on the right can help you.<!-- Please ensure all communication adheres to the code of conduct. -->
GitHub (Jan 10 2020 at 10:08):bnjbvr submitted PR Review.
GitHub (Jan 10 2020 at 12:40):sunfishcode merged PR #1329.
Last updated: Oct 23 2024 at 20:03 UTC