Stream: git-cranelift

Topic: cranelift / PR #1307 cranelift-wasm: Check for `u32::MAX`...


view this post on Zulip GitHub (Dec 20 2019 at 23:01):

fitzgen opened PR #1307 from fix-1306 to master:

As an implementation-specific limit, we do not allow the full index space of 0..=2^21 - 1 because we reserve index 2^32 - 1 for ourselves in cranelift-entity.

Fixes #1306

view this post on Zulip GitHub (Dec 20 2019 at 23:01):

fitzgen requested abrown for a review on PR #1307.

view this post on Zulip GitHub (Dec 20 2019 at 23:01):

fitzgen edited PR #1307 from fix-1306 to master:

As an implementation-specific limit, we do not allow the full index space of 0..=2^32 - 1 because we reserve index 2^32 - 1 for ourselves in cranelift-entity.

Fixes #1306

view this post on Zulip GitHub (Dec 20 2019 at 23:01):

fitzgen updated PR #1307 from fix-1306 to master:

As an implementation-specific limit, we do not allow the full index space of 0..=2^32 - 1 because we reserve index 2^32 - 1 for ourselves in cranelift-entity.

Fixes #1306

view this post on Zulip GitHub (Dec 21 2019 at 00:47):

sunfishcode submitted PR Review.

view this post on Zulip GitHub (Dec 21 2019 at 01:37):

fitzgen updated PR #1307 from fix-1306 to master:

As an implementation-specific limit, we do not allow the full index space of 0..=2^32 - 1 because we reserve index 2^32 - 1 for ourselves in cranelift-entity.

Fixes #1306

view this post on Zulip GitHub (Dec 21 2019 at 21:36):

abrown submitted PR Review.

view this post on Zulip GitHub (Dec 21 2019 at 21:37):

abrown merged PR #1307.


Last updated: Dec 23 2024 at 13:07 UTC