Stream: git-cranelift

Topic: cranelift / PR #1301 Merge emit_small_memcpy and emit_sma...

GitHub (Dec 19 2019 at 20:16):

bjorn3 opened PR #1301 from group_small_memcpy_load_store to master:

• [x] This has been discussed in issue #..., or if not, please tell us why
  here. This is mostly a cleanup.

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first. They share a lot of code. Also by performing all loads before all stores, the performance of the simple-raytracer cg_clif benchmark increases by 1%.

• [x] This PR contains test cases, if meaningful. N/A

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so and/or ping
  bnjbvr. <strike>The list of suggested reviewers on the right can help you.</strike> (no list for non members)

<!-- Please ensure all communication adheres to the code of conduct. -->

GitHub (Dec 19 2019 at 20:17):

bjorn3 updated PR #1301 from group_small_memcpy_load_store to master:

• [x] This has been discussed in issue #..., or if not, please tell us why
  here. This is mostly a cleanup.

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first. They share a lot of code. Also by performing all loads before all stores, the performance of the simple-raytracer cg_clif benchmark increases by 1%.

• [x] This PR contains test cases, if meaningful. N/A

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so and/or ping
  bnjbvr. <strike>The list of suggested reviewers on the right can help you.</strike> (no list for non members)

<!-- Please ensure all communication adheres to the code of conduct. -->

GitHub (Dec 19 2019 at 21:32):

bjorn3 submitted PR Review.

GitHub (Dec 19 2019 at 21:32):

bjorn3 submitted PR Review.

GitHub (Dec 19 2019 at 21:32):

bjorn3 created PR Review Comment:

Pre-existing, but this needs to compare {src,dest}_align with access_size.

GitHub (Feb 13 2020 at 10:44):

bnjbvr requested eqrion for a review on PR #1301.

GitHub (Feb 14 2020 at 19:06):

eqrion submitted PR Review.

GitHub (Feb 14 2020 at 19:06):

eqrion created PR Review Comment:

src cq dest

Is cq a typo or am I missing an abbreviation?

GitHub (Feb 14 2020 at 19:06):

eqrion submitted PR Review.

GitHub (Feb 14 2020 at 19:14):

bjorn3 updated PR #1301 from group_small_memcpy_load_store to master:

• [x] This has been discussed in issue #..., or if not, please tell us why
  here. This is mostly a cleanup.

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first. They share a lot of code. Also by performing all loads before all stores, the performance of the simple-raytracer cg_clif benchmark increases by 1%.

• [x] This PR contains test cases, if meaningful. N/A

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so and/or ping
  bnjbvr. <strike>The list of suggested reviewers on the right can help you.</strike> (no list for non members)

<!-- Please ensure all communication adheres to the code of conduct. -->

GitHub (Feb 14 2020 at 19:14):

bjorn3 created PR Review Comment:

It seems that cq is a Dutch abbreviation: https://nl.m.wikipedia.org/wiki/Casu_quo. I also used it wrong. :man_facepalming: I meant: src_align is the upper-bound on the alignment of src and dest_align is the upper-bound on the alignment of dest. I replaced it with respectively.

GitHub (Feb 14 2020 at 19:14):

bjorn3 submitted PR Review.

GitHub (Feb 14 2020 at 22:44):

eqrion merged PR #1301.

Last updated: Dec 23 2024 at 13:07 UTC