Stream: git-cranelift

Topic: cranelift / PR #1285 Fix SIMD float comparison encoding

view this post on Zulip GitHub (Jan 07 2020 at 18:55):

abrown updated PR #1285 from fix-float-compare to master:

The Intel manual uses CMPNLT and CMPNLE to denote not-less-than and not-less-than-or-equals. These were translated previously to FloatCC::GreaterThan and FloatCC::GreaterThanOrEqual but should be correctly translated to FloatCC::UnorderedOrGreaterThanOrEqual and FloatCC::UnorderedOrGreaterThan. This change adds the necessary legalizations to make use of these new encodings.

view this post on Zulip GitHub (Jan 08 2020 at 09:59):

bnjbvr requested julian-seward1 for a review on PR #1285.

view this post on Zulip GitHub (Jan 08 2020 at 10:07):

julian-seward1 submitted PR Review.

view this post on Zulip GitHub (Jan 08 2020 at 10:07):

julian-seward1 submitted PR Review.

view this post on Zulip GitHub (Jan 08 2020 at 10:07):

julian-seward1 created PR Review Comment:

Yes, that's better. Thanks.

view this post on Zulip GitHub (Jan 08 2020 at 17:28):

abrown merged PR #1285.

Last updated: Dec 06 2025 at 06:05 UTC