jyn514 updated PR #1209 from zeroinit
to master
:
[ ] This has been discussed in issue #..., or if not, please tell us why
here.
This has not been discussed yet. Discussion of why this feature was implemented is in https://github.com/m4b/faerie/issues/97.[x] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.
This uses the newzero_init
api for Faerie, which uses.bss
sections to reduce the amount of space binaries take up in memory (while being generated) and on disk (when stored).[ ] This PR contains test cases, if meaningful.
This PR does not contain new test cases. All existing test cases pass.[ ] A reviewer from the core maintainer team has been assigned for this PR.
I am not sure who should review this.
jyn514 updated PR #1209 from zeroinit
to master
:
[ ] This has been discussed in issue #..., or if not, please tell us why
here.
This has not been discussed yet. Discussion of why this feature was implemented is in https://github.com/m4b/faerie/issues/97.[x] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.
This uses the newzero_init
api for Faerie, which uses.bss
sections to reduce the amount of space binaries take up in memory (while being generated) and on disk (when stored).[ ] This PR contains test cases, if meaningful.
This PR does not contain new test cases. All existing test cases pass.[ ] A reviewer from the core maintainer team has been assigned for this PR.
I am not sure who should review this.
jyn514 updated PR #1209 from zeroinit
to master
:
[ ] This has been discussed in issue #..., or if not, please tell us why
here.
This has not been discussed yet. Discussion of why this feature was implemented is in https://github.com/m4b/faerie/issues/97.[x] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.
This uses the newzero_init
api for Faerie, which uses.bss
sections to reduce the amount of space binaries take up in memory (while being generated) and on disk (when stored).[ ] This PR contains test cases, if meaningful.
This PR does not contain new test cases. All existing test cases pass.[ ] A reviewer from the core maintainer team has been assigned for this PR.
I am not sure who should review this.
philipc submitted PR Review.
philipc submitted PR Review.
philipc created PR Review Comment:
Init::Zeros { size } => {
philipc created PR Review Comment:
philipc created PR Review Comment:
Ok, but verbose for a problem that can't occur in practice. Personally I would do
size as u64
.
jyn514 updated PR #1209 from zeroinit
to master
:
[ ] This has been discussed in issue #..., or if not, please tell us why
here.
This has not been discussed yet. Discussion of why this feature was implemented is in https://github.com/m4b/faerie/issues/97.[x] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.
This uses the newzero_init
api for Faerie, which uses.bss
sections to reduce the amount of space binaries take up in memory (while being generated) and on disk (when stored).[ ] This PR contains test cases, if meaningful.
This PR does not contain new test cases. All existing test cases pass.[ ] A reviewer from the core maintainer team has been assigned for this PR.
I am not sure who should review this.
jyn514 updated PR #1209 from zeroinit
to master
:
[ ] This has been discussed in issue #..., or if not, please tell us why
here.
This has not been discussed yet. Discussion of why this feature was implemented is in https://github.com/m4b/faerie/issues/97.[x] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.
This uses the newzero_init
api for Faerie, which uses.bss
sections to reduce the amount of space binaries take up in memory (while being generated) and on disk (when stored).[ ] This PR contains test cases, if meaningful.
This PR does not contain new test cases. All existing test cases pass.[ ] A reviewer from the core maintainer team has been assigned for this PR.
I am not sure who should review this.
Last updated: Dec 23 2024 at 14:03 UTC