Stream: git-cranelift

Topic: cranelift / PR #1209 Use new zeroinit API for faerie

GitHub (Feb 07 2020 at 02:37):

jyn514 updated PR #1209 from zeroinit to master:

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.
  This has not been discussed yet. Discussion of why this feature was implemented is in https://github.com/m4b/faerie/issues/97.

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.
  This uses the new zero_init api for Faerie, which uses .bss sections to reduce the amount of space binaries take up in memory (while being generated) and on disk (when stored).

• [ ] This PR contains test cases, if meaningful.
  This PR does not contain new test cases. All existing test cases pass.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  I am not sure who should review this.

GitHub (Feb 07 2020 at 02:48):

jyn514 updated PR #1209 from zeroinit to master:

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.
  This has not been discussed yet. Discussion of why this feature was implemented is in https://github.com/m4b/faerie/issues/97.

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.
  This uses the new zero_init api for Faerie, which uses .bss sections to reduce the amount of space binaries take up in memory (while being generated) and on disk (when stored).

• [ ] This PR contains test cases, if meaningful.
  This PR does not contain new test cases. All existing test cases pass.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  I am not sure who should review this.

GitHub (Feb 07 2020 at 02:49):

jyn514 updated PR #1209 from zeroinit to master:

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.
  This has not been discussed yet. Discussion of why this feature was implemented is in https://github.com/m4b/faerie/issues/97.

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.
  This uses the new zero_init api for Faerie, which uses .bss sections to reduce the amount of space binaries take up in memory (while being generated) and on disk (when stored).

• [ ] This PR contains test cases, if meaningful.
  This PR does not contain new test cases. All existing test cases pass.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  I am not sure who should review this.

GitHub (Feb 07 2020 at 04:05):

philipc submitted PR Review.

GitHub (Feb 07 2020 at 04:05):

philipc submitted PR Review.

GitHub (Feb 07 2020 at 04:05):

philipc created PR Review Comment:

            Init::Zeros { size } => {

GitHub (Feb 07 2020 at 04:05):

philipc created PR Review Comment:

GitHub (Feb 07 2020 at 04:05):

philipc created PR Review Comment:

Ok, but verbose for a problem that can't occur in practice. Personally I would do size as u64.

GitHub (Feb 07 2020 at 04:10):

jyn514 updated PR #1209 from zeroinit to master:

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.
  This has not been discussed yet. Discussion of why this feature was implemented is in https://github.com/m4b/faerie/issues/97.

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.
  This uses the new zero_init api for Faerie, which uses .bss sections to reduce the amount of space binaries take up in memory (while being generated) and on disk (when stored).

• [ ] This PR contains test cases, if meaningful.
  This PR does not contain new test cases. All existing test cases pass.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  I am not sure who should review this.

GitHub (Feb 07 2020 at 04:12):

jyn514 updated PR #1209 from zeroinit to master:

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.
  This has not been discussed yet. Discussion of why this feature was implemented is in https://github.com/m4b/faerie/issues/97.

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.
  This uses the new zero_init api for Faerie, which uses .bss sections to reduce the amount of space binaries take up in memory (while being generated) and on disk (when stored).

• [ ] This PR contains test cases, if meaningful.
  This PR does not contain new test cases. All existing test cases pass.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  I am not sure who should review this.

Last updated: Nov 22 2024 at 17:03 UTC