Stream: git-cranelift

Topic: cranelift / Issue #956 Should we re-organize crates withi...

GitHub (Jan 10 2020 at 10:40):

bnjbvr commented on Issue #956:

ping @fitzgen, any updates about this idea?

GitHub (Jan 10 2020 at 17:43):

fitzgen commented on Issue #956:

We did this in wasmtime. Still +1 for doing it here too.

Happy to make a PR if others are on board!

GitHub (Jan 10 2020 at 18:27):

bnjbvr labeled Issue #956:

While there isn't really One True Way to organize a workspace and the crates within it that is adopted by a majority of the rust ecosystem, of the different ways to do it, the most prevalent convention I've seen is:

• to have the main, public facing crate in the root of the repo (ie the cranelift crate)
• for all sub crates cranelift-foo, put them at crates/foo

For example, both cargo and wasm-bindgen follow this convention.

How do folks feel about switching to this layout?

See also https://github.com/CraneStation/wasmtime/pull/305 for this same thing for wasmtime.

GitHub (Jan 13 2020 at 13:39):

bnjbvr commented on Issue #956:

I realize that my fuzzy-search auto-complete tooling in terminals will be less effective, if we did this. Currently, I can type "gen" for "cranelift-codegen", but with the additional "crates" directory, I won't be able to do this. It's a minor annoyance, if there was a way to fix it (use special paths for Cargo.toml files and the src directory they refer to?) it'd be nice, otherwise i can live with it.

GitHub (Feb 28 2020 at 23:26):

alexcrichton transferred Issue #956:

While there isn't really One True Way to organize a workspace and the crates within it that is adopted by a majority of the rust ecosystem, of the different ways to do it, the most prevalent convention I've seen is:

• to have the main, public facing crate in the root of the repo (ie the cranelift crate)
• for all sub crates cranelift-foo, put them at crates/foo

For example, both cargo and wasm-bindgen follow this convention.

How do folks feel about switching to this layout?

See also https://github.com/CraneStation/wasmtime/pull/305 for this same thing for wasmtime.

Last updated: Dec 23 2024 at 13:07 UTC