bnjbvr commented on Issue #866:
@nbp ping? (see previous comment)
nbp milestoned Issue #866:
This changes are replacing the iteration over all instructions by an iteration over the last 2 instructions of basic blocks, when
basic-blocks
feature is enabled.I am confident this change is likely improving performances. However, until the front-end is completely fixed to generate valid basic blocks, we have no way to check the performances of this code on benchmarks.
I tried running the test suite, but it takes less than a second, which does not give me much confidence.
nbp demilestoned Issue #866:
This changes are replacing the iteration over all instructions by an iteration over the last 2 instructions of basic blocks, when
basic-blocks
feature is enabled.I am confident this change is likely improving performances. However, until the front-end is completely fixed to generate valid basic blocks, we have no way to check the performances of this code on benchmarks.
I tried running the test suite, but it takes less than a second, which does not give me much confidence.
nbp commented on Issue #866:
I think this PR was quite complete at the time, it was only a draft as it depend on the "new" bb.
eqrion commented on Issue #866:
This looks good to me. @nbp do you have time to rebase this? If not I can take this and rebase it.
This will require a change now that #1363 has been merged, as the feature gate has been removed.
eqrion commented on Issue #866:
This looks good to me. @nbp do you have time to rebase this? If not I can take this and rebase it.
This will require a change now that #1363 has been merged, as the feature gate has been removed.
I'm going to work on this after #1365 is merged. I don't this commit will apply at all after then, so I'll probably end up rewriting it and attributing @nbp.
Last updated: Dec 23 2024 at 13:07 UTC