Stream: git-cranelift

Topic: cranelift / Issue #863 Better public API for cranelift-fr...

view this post on Zulip GitHub (Feb 28 2020 at 23:26):

alexcrichton transferred Issue #863:

In https://github.com/CraneStation/cranelift/pull/862 we added commentary to specify what "pristine" and "filled" meant. Nicolas pointed out that the commentary makes it clear that it could really just be some EbbState enum, for example:

enum EbbState {
  UnChanged,
  Changed,
  ChangedAndTerminated,
}

This would help us make better sense of the public interface, where is_pristine() and is_filled() functions are part of the FunctionBuilder public API (used by cranelift-wasm), but it isn't clear what those words refer to, so you have to go digging around.

Last updated: Oct 23 2024 at 20:03 UTC