Stream: git-cranelift

Topic: cranelift / Issue #1400 add a "raw" function definition i...

view this post on Zulip GitHub (Feb 21 2020 at 19:45):

bjorn3 commented on Issue #1400:

When running in the context of perf the PERF_BUILDID_DIR env var is set. By creating a map file, perf is able to map addresses of jitted functions back to their name.

(original author of that code speaking here)

view this post on Zulip GitHub (Feb 21 2020 at 20:51):

pchickey commented on Issue #1400:

@bjorn3 thanks. In that case, I agree with your suggestion that it be factored out to a common func, and it would be good to see that explanation in a comment there

view this post on Zulip GitHub (Feb 21 2020 at 22:10):

froydnj commented on Issue #1400:

Thanks for the reviews! I added a commit with a comment that I think satisfies @pchickey's request.

Last updated: Nov 22 2024 at 17:03 UTC