GitHub (Feb 14 2020 at 21:52): GitHub (Feb 14 2020 at 21:52):abrown commented on Issue #1370:
@iximeow, thanks for all of the help! (And @peterhuene too!) I believe this is ready for an actual review--@iximeow, can you take a look? I rebased the commits into some semblance of order so they should be reviewable from oldest to newest (fun fact of the day: I had to redate them for GitHub to show them in order). Since we likely won't want to squash these things, I made sure the commits are bisectable by running
git rebase master --exec 'cargo test --all'with no issues.I would like to be able to actually run this new instruction on AVX512 hardware with a
test runfiletest but I will try that in a future PR; currently I don't think we have the ability to skiptest runfiletests when the target doesn't match the host's CPU features (or do we?).
GitHub (Mar 05 2020 at 15:13):bnjbvr commented on Issue #1370:
Closing in favor of https://github.com/bytecodealliance/wasmtime/pull/1192.
Last updated: Nov 22 2024 at 16:03 UTC