GitHub (Feb 03 2020 at 17:28): GitHub (Feb 03 2020 at 17:28):abrown commented on Issue #1365:
@eqrion, this makes sense to me. Why don't we mark this ready for review?
GitHub (Feb 03 2020 at 17:40):eqrion commented on Issue #1365:
@eqrion, this makes sense to me. Why don't we mark this ready for review?
I just realized that I had forgotten to clean up the ordering of the commits. I'll do that first and then mark this ready for review.
GitHub (Feb 03 2020 at 17:42):abrown commented on Issue #1365:
I think we will want to "squash and merge" this PR to make it atomic?
GitHub (Feb 04 2020 at 21:46):eqrion commented on Issue #1365:
Yeah, this is probably ready for review. I see there are now conflicts. I think the best way forward is to review this as-is, and then when we're ready to merge I can rebase by re-creating the automatic rename commits.
Last updated: Dec 23 2024 at 14:03 UTC