Stream: git-cranelift

Topic: cranelift / Issue #1358 add `impl Deref<Target=HashMap>` ...

GitHub (Jan 19 2020 at 20:02):

bjorn3 commented on Issue #1358:

I would prefer an entries method like you suggested in the issue instead. Otherwise it is easy to accidentially use a method from the internal HashMap. This will also polute autocompletion suggestions and the docs with every single HashMap method.

GitHub (Jan 19 2020 at 20:05):

jyn514 commented on Issue #1358:

I changed it to entries, that makes sense. Users can still have all the len(), is_empty(), etc. functions by calling entries() first.

Last updated: Dec 23 2024 at 13:07 UTC