Stream: git-cranelift

Topic: cranelift / Issue #1348 Replace temporary lowering of Was...

GitHub (Jan 14 2020 at 23:29):

abrown opened Issue #1348:

What is the feature or code improvement you would like to do in Cranelift?

In #1347 I added a temporary lowering for Wasm's load_splat to two Cranelift instructions, load + splat. This generates extra instructions that could be removed by a specialized Cranelift load_splat instruction or by smarter codegen (e.g. complex addressing on splat).

What is the value of adding this in Cranelift?

Fewer instructions produced.

Do you have an implementation plan, and/or ideas for data structures or algorithms to use?

Seeking feedback on which way to proceed: specialized load_splat or smarter codegen.

Have you considered alternative implementations? If so, how are they better or worse than your proposal?

See above.

GitHub (Jan 14 2020 at 23:34):

abrown edited Issue #1348:

What is the feature or code improvement you would like to do in Cranelift?

In #1347 I added a temporary lowering for Wasm's load_splat to two Cranelift instructions, load + splat. This generates extra instructions that could be removed by a specialized Cranelift load_splat instruction or by smarter codegen (e.g. complex addressing on splat).

What is the value of adding this in Cranelift?

Fewer instructions produced.

Do you have an implementation plan, and/or ideas for data structures or algorithms to use?

Seeking feedback on which way to proceed: specialized load_splat or smarter codegen.

Have you considered alternative implementations? If so, how are they better or worse than your proposal?

See above.

GitHub (Jan 14 2020 at 23:35):

abrown commented on Issue #1348:

@sunfishcode, I wonder if the load-from-constant-table questions I was asking also relate to this (in regard to the complex addressing).

GitHub (Feb 28 2020 at 23:28):

alexcrichton transferred Issue #1348:

What is the feature or code improvement you would like to do in Cranelift?

In #1347 I added a temporary lowering for Wasm's load_splat to two Cranelift instructions, load + splat. This generates extra instructions that could be removed by a specialized Cranelift load_splat instruction or by smarter codegen (e.g. complex addressing on splat).

What is the value of adding this in Cranelift?

Fewer instructions produced.

Do you have an implementation plan, and/or ideas for data structures or algorithms to use?

Seeking feedback on which way to proceed: specialized load_splat or smarter codegen.

Have you considered alternative implementations? If so, how are they better or worse than your proposal?

See above.

Last updated: Dec 23 2024 at 13:07 UTC