GitHub (Jan 10 2020 at 22:37): GitHub (Jan 10 2020 at 22:37):alexcrichton commented on Issue #1336:
I've tested this out locally with my own suite of cranelift crates. The publication step looks like this and the PR step looks like this.
Note that to merge this we'll need to add a crates.io token to the secret environment variables of this repository. I think the best thing to do is to set up a new user which only controls these crates. That way the token only has access to these crates, no other crates (such as another users's crates if we used one of our own personal tokens). For this purpose I've set up a user https://github.com/cranelift-auto-publish which now has a crates.io account. If everyone's ok with this setup I'll configure the registry tokens and such before this merges.
GitHub (Jan 10 2020 at 22:41):abrown commented on Issue #1336:
I feel like the two-step process is what is tripping us up right now; is there any way to do the version bump and tagging all in the same PR?
GitHub (Jan 10 2020 at 22:45):alexcrichton commented on Issue #1336:
Heh well technically CI allows us to do anything so everything is in the realm of possibility! It's largely just a question of what we want this to look like.
We could possibly forgo the tags entirely, and have a scheme where every merge to master compares versions against crates.io and if they changed the crate is published. I personally like the system of tags myself because it's pretty lightweight but still has a deliberate "this is the thing I'm releasing step", but I'm down for implementing whatever!
GitHub (Jan 10 2020 at 22:55):abrown commented on Issue #1336:
I'll defer to @sunfishcode and @bnjbvr since they will likely be the ones doing this type of stuff :big_smile:.
GitHub (Feb 28 2020 at 23:36):alexcrichton commented on Issue #1336:
I'm gonna close this and we can recreate it later if still necessary on the wasmtime repo.
Last updated: Nov 22 2024 at 17:03 UTC