cranelift / Issue #1317 Improve support for reference-types · git-cranelift

Stream: git-cranelift

Topic: cranelift / Issue #1317 Improve support for reference-types

GitHub (Jan 13 2020 at 20:39):

I've found an issue through more extensive testing, this isn't ready for review.

GitHub (Jan 21 2020 at 16:57):

I've found an issue through more extensive testing, this isn't ready for review.

That was a false alarm, I was getting a timeout in a non-standard configuration. Upon further investigation, it looks like it's just caused by a very slow implementation of barriers. So this should be ready for review.

GitHub (Jan 22 2020 at 16:01):

eqrion commented on Issue #1317:

Code looks good to me, but I think it should be possible to have some tests, right? I don't think we actually need to manufacture any reference types to have tests (which would require askign how we're going to manage their lifetimes) and can instead have test functions that take r32 and r64 parameters and put them in tables and all that. I think we should be able to do that even in the dummy environment.

That seems plausible to me. I'm not very familiar with the testing architecture, so I'll need to do some investigation. I'll try to do that today or tomorrow.

GitHub (Jan 23 2020 at 15:36):

eqrion commented on Issue #1317:

I've now added a basic test for r32 and r64, removed the out-of-date comments, and updated the documentation on StackMap to more thoroughly explain the representation.

Last updated: Oct 23 2024 at 20:03 UTC