GitHub (Jan 06 2020 at 11:11): GitHub (Jan 06 2020 at 11:11):bnjbvr opened Issue #1315:
Landing #1308 introduced new test failures, as caught by CI in both the pull request and on master. Please make sure that a PR passes CI before merging.
I will look at it quickly, and if the fix isn't obvious I'll immediately revert the patch.
cc @bjorn3 @sstangl
GitHub (Jan 06 2020 at 11:11):bnjbvr labeled Issue #1315:
Landing #1308 introduced new test failures, as caught by CI in both the pull request and on master. Please make sure that a PR passes CI before merging.
I will look at it quickly, and if the fix isn't obvious I'll immediately revert the patch.
cc @bjorn3 @sstangl
GitHub (Jan 06 2020 at 11:43):bjorn3 commented on Issue #1315:
Sorry for the trouble, I hadn't noticed that there were test failures. It looks like those tests just need to be updated to use the correct recipe name.
GitHub (Jan 06 2020 at 13:39):bnjbvr commented on Issue #1315:
Fixed by #1316.
GitHub (Jan 06 2020 at 13:39):bnjbvr closed Issue #1315:
Landing #1308 introduced new test failures, as caught by CI in both the pull request and on master. Please make sure that a PR passes CI before merging.
I will look at it quickly, and if the fix isn't obvious I'll immediately revert the patch.
cc @bjorn3 @sstangl
Last updated: Nov 22 2024 at 17:03 UTC