Stream: git-cranelift

Topic: cranelift / Issue #1313 Derive Ord for all entities

view this post on Zulip GitHub (Dec 27 2019 at 19:16):

sstangl commented on Issue #1313:

What's the use case for this? The internal number assigned to an entity is basically arbitrary.

view this post on Zulip GitHub (Dec 27 2019 at 19:55):

bjorn3 commented on Issue #1313:

I want to use a BTreeMap instead of HashMap for determinism. Value and Inst already derive Ord.

view this post on Zulip GitHub (Jan 22 2020 at 09:49):

bnjbvr commented on Issue #1313:

ping @bjorn3, can you address Sean's comment, rebase, and make sure your tests pass, please? Thanks!

view this post on Zulip GitHub (Jan 22 2020 at 16:57):

bjorn3 commented on Issue #1313:

Rebased and addressed comment.

view this post on Zulip GitHub (Jan 22 2020 at 17:18):

bnjbvr commented on Issue #1313:

Thank you!

Last updated: Oct 23 2024 at 20:03 UTC