Stream: git-cranelift

Topic: cranelift / Issue #1307 cranelift-wasm: Check for `u32::M...

GitHub (Dec 20 2019 at 23:06):

fitzgen commented on Issue #1307:

We should probably not have only "infallible" constructors for entity indices, when you can give "invalid" inputs to them... That is, I think we should have

• FuncIndex::try_from_u32(u32) -> Result<Self, SomeErrorType>
• FuncIndex::from_u32(u32) -> Self and panics if given u32::MAX
• FuncIndex::from_u32_unchecked(u32) -> Self which only debug-asserts that it is not given u32::MAX (aka the current behavior of from_u32)

But this is a bit more invasive and has implications across cranelift, so I've opted not to do it, for now at least.

GitHub (Dec 21 2019 at 00:48):

sunfishcode commented on Issue #1307:

Also, fwiw, your suggestion about try_from_u32 etc. makes sense to me.

GitHub (Dec 21 2019 at 01:27):

fitzgen commented on Issue #1307:

Is it feasible to check in the test file in wat format, rather than wasm?

Not that I know of (I could be wrong!) since this is something that requires semi-bogus custom section data. I don't know how to write WAT like that.

GitHub (Dec 21 2019 at 01:39):

fitzgen commented on Issue #1307:

it's useful to give the test a descriptive name

Updated the name to issue-1306-name-section-with-u32-max-function-index.wasm, let me know if you want it to be something else.

Last updated: Oct 23 2024 at 20:03 UTC