wasmtime_wasi::preview2::command::add_to_linker · wasmtime

Stream: wasmtime

Topic: wasmtime_wasi::preview2::command::add_to_linker

Joel Dice (Nov 30 2023 at 00:31):

Two questions regarding wasmtime_wasi::preview2::command::add_to_linker (and its sync counterpart):

Why is it written by hand rather than reusing the wasmtime-wit-bindgen-generated add_to_linker function for the command world?
Why does it not include random::insecure::add_to_linker or random::insecure_seed::add_to_linker, given that those are part of the command world?

Joel Dice (Nov 30 2023 at 00:32):

(if the latter is simply a mistake, I can PR a fix)

Joel Dice (Nov 30 2023 at 00:38):

(Context: it's currently impossible to run a componentize-py-generated CLI app using wasmtime run because the linker provides neither wasi:random/insecure nor wasi:random/insecure_seed)

Alex Crichton (Nov 30 2023 at 00:42):

Why is it written by hand

It should be using the generated version if that works, I think it was an in-development artifact not using that, but no reason otherwise.

Why does it not include random::insecure

I believe that's a bug!

Joel Dice (Nov 30 2023 at 00:45):

PR to address the omissions: https://github.com/bytecodealliance/wasmtime/pull/7613

include `wasi:random/insecure{_seed}` in `command::add_to_linker` by dicej · Pull Request #7613 · bytecodealliance/wasmtime

I believe these were omitted by mistake. TODO: We should definitely use the wasmtime-wit-bindgen-generated add_to_linker function for the command world if possible, which would avoid such mistakes ...

Last updated: Dec 23 2024 at 14:03 UTC