fitzgen (he/him) (Feb 05 2020 at 16:58): fitzgen (he/him) (Feb 05 2020 at 16:58):@Yury Delendik the compare-master.sh job on wasmparser's CI is quite slow... it's been running for 23 minutes with zero output. How much value do you get out of it? I'd also expect that its results are not too reliable on CI servers. Does it make sense to keep this job around?
fitzgen (he/him) (Feb 05 2020 at 17:21):anyways, made a few fixups over here: https://github.com/bytecodealliance/wasmparser/pull/187
fitzgen (he/him) (Feb 05 2020 at 18:10):passing an hour and a half... I think we should probably axe this ci job. sound good @Yury Delendik?
Yury Delendik (Feb 05 2020 at 18:12):sure
Yury Delendik (Feb 05 2020 at 18:14):I will disable "./compare-master.sh" for now
Dan Gohman (Feb 07 2020 at 23:59):Anyone know why lightbeam is failing spec tests now?
fitzgen (he/him) (Feb 08 2020 at 00:22):master CI looks green -- are you seeing failures locally?
Dan Gohman (Feb 08 2020 at 00:24):Yeah. cargo +nightly test --features lightbeam
Dan Gohman (Feb 08 2020 at 00:24):Lots of failures like
Dan Gohman (Feb 08 2020 at 00:24):---- Lightbeam::spec_testsuite::int_exprs stdout ----
thread 'Lightbeam::spec_testsuite::int_exprs' panicked at 'assertion failed: (left == right)
left: Int(_32),
right: Int(_64)', <::std::macros::panic macros>:5:6
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
Dan Gohman (Feb 08 2020 at 00:46):It appears we're not testing with --features lightbeam enabled. Arg.
Dan Gohman (Feb 08 2020 at 01:06):It's because lightbeam isn't updated for the caller-vmctx change. I'm trying to see if I can fix it.
Last updated: Oct 23 2024 at 20:03 UTC