@Yury Delendik the compare-master.sh
job on wasmparser's CI is quite slow... it's been running for 23 minutes with zero output. How much value do you get out of it? I'd also expect that its results are not too reliable on CI servers. Does it make sense to keep this job around?
anyways, made a few fixups over here: https://github.com/bytecodealliance/wasmparser/pull/187
passing an hour and a half... I think we should probably axe this ci job. sound good @Yury Delendik?
sure
I will disable "./compare-master.sh" for now
Anyone know why lightbeam is failing spec tests now?
master CI looks green -- are you seeing failures locally?
Yeah. cargo +nightly test --features lightbeam
Lots of failures like
---- Lightbeam::spec_testsuite::int_exprs stdout ----
thread 'Lightbeam::spec_testsuite::int_exprs' panicked at 'assertion failed: (left == right)
left: Int(_32)
,
right: Int(_64)
', <::std::macros::panic macros>:5:6
note: run with RUST_BACKTRACE=1
environment variable to display a backtrace
It appears we're not testing with --features lightbeam enabled. Arg.
It's because lightbeam isn't updated for the caller-vmctx change. I'm trying to see if I can fix it.
Last updated: Dec 23 2024 at 14:03 UTC