Stream: wasmtime

Topic: sock_accept

Harald Hoyer (Jan 27 2022 at 12:02):

Ready for review:
https://github.com/bytecodealliance/wasmtime/pull/3711

I am here to answer all questions regarding this PR.

Harald Hoyer (Jan 27 2022 at 12:12):

Opened a networking issue:
https://github.com/bytecodealliance/wasmtime/issues/3730

Harald Hoyer (Jan 27 2022 at 13:09):

I might need help with creating tests for this.

Harald Hoyer (Jan 28 2022 at 12:40):

So the rust-lang PR https://github.com/rust-lang/rust/pull/93158 is basically approved, besides the SocketAddr::new(Ipv4Addr::UNSPECIFIED.into(), 0) part

Harald Hoyer (Jan 31 2022 at 13:09):

The rust-lang PR is merged :party_ball:

Nathaniel McCallum (Jan 31 2022 at 23:31):

@Dan Gohman The above PR is currently blocking our Enarx release. When is the next scheduled wasmtime release? Would it be possible to get a backported point release?

Dan Gohman (Jan 31 2022 at 23:35):

@Nathaniel McCallum I think it's ready to go, based on my previous readthrough; I'm planning to make one more pass today to see if there's anything I missed, and then approve and merge it.

Nathaniel McCallum (Jan 31 2022 at 23:35):

@Dan Gohman Thanks! Presuming it is merged today, when can we see it in a release?

Dan Gohman (Jan 31 2022 at 23:36):

That'll folllow the release process

Nathaniel McCallum (Jan 31 2022 at 23:38):

@Dan Gohman I'm aware of that. However, it doesn't appear to be followed yet: https://github.com/bytecodealliance/wasmtime/tags

Nathaniel McCallum (Jan 31 2022 at 23:39):

@Dan Gohman If it were being followed, we would see a release in two days.

Dan Gohman (Jan 31 2022 at 23:46):

@Nathaniel McCallum After the PR lands, I'll ping some folks and see if we can get a release out soon after.

Nathaniel McCallum (Jan 31 2022 at 23:47):

@Dan Gohman Perfect! Thanks! We have no interest in abusing the process.

Dan Gohman (Jan 31 2022 at 23:48):

The main thing right now is just that it's a new process and it's still in the process of settling down.

Nathaniel McCallum (Jan 31 2022 at 23:50):

@Dan Gohman We completely understand. We look forward to predictability.

Dan Gohman (Feb 01 2022 at 00:26):

@Nathaniel McCallum It's now merged. I'll ping people tomorrow and see what we can do.

Till Schneidereit (Feb 01 2022 at 11:20):

we are following the release process—we're just not doing major releases yet. So we should have 0.34.0 out in a few days

Nathaniel McCallum (Feb 01 2022 at 14:10):

@Till Schneidereit That timing works well for us. Thanks!

Nathaniel McCallum (Feb 01 2022 at 15:06):

@Till Schneidereit Can we rely on a 4-week cadence going forward? If so, we'll do the same cadence with a 1-week offset.

Till Schneidereit (Feb 01 2022 at 15:14):

@Nathaniel McCallum yes, you can. See the release handling RFC for details and some small caveats around holidays and so on

Nathaniel McCallum (Feb 01 2022 at 15:35):

@Till Schneidereit Does this mean you intend to release on Tuesday, Feb 8?

Till Schneidereit (Feb 01 2022 at 15:41):

cc @Alex Crichton for the exact schedule

Alex Crichton (Feb 01 2022 at 15:44):

I believe we receive a PR on the 5th, and when it's merged after that the release is made

Nathaniel McCallum (Feb 01 2022 at 21:21):

@Alex Crichton Thanks!

Harald Hoyer (Feb 04 2022 at 10:46):

updated and rebased the CLI PR
https://github.com/bytecodealliance/wasmtime/pull/3729

Last updated: Nov 22 2024 at 17:03 UTC