Stream: wasmtime

Topic: resources PR

view this post on Zulip Dan Gohman (Sep 29 2023 at 19:22):

#7091 has now landed, and the resources PR is now rebased on top of it, and all review comments are addressed. Can we land this? :smile: @Alex Crichton @Pat Hickey

Start to port Wasmtime to the new wasi-io API with resources. by sunfishcode · Pull Request #7029 · bytecodealliance/wasmtime
This imports the new APIs posted in WebAssembly/wasi-io#46.

view this post on Zulip Alex Crichton (Sep 29 2023 at 19:22):

A+ from me

view this post on Zulip Alex Crichton (Sep 29 2023 at 19:22):

feel free to hit the button

view this post on Zulip Dan Gohman (Sep 29 2023 at 19:24):

button pushed, it's in the queue!

view this post on Zulip Pat Hickey (Sep 29 2023 at 19:43):

great work dan, this was a huge pr

view this post on Zulip Dan Gohman (Sep 29 2023 at 19:56):

thanks, and thanks to Alex for all the help with this PR!

view this post on Zulip Dan Gohman (Sep 29 2023 at 20:44):

And it's now merged!

view this post on Zulip Dan Gohman (Sep 29 2023 at 20:47):

If someone is around who could r+ https://github.com/WebAssembly/wit-abi-up-to-date/pull/17 then I'll go and land all the wasi proposal repo PRs next.

Update to wit-bindgen 0.12.0. by sunfishcode · Pull Request #17 · WebAssembly/wit-abi-up-to-date
In particular, this has bytecodealliance/wit-bindgen#670, which fixes a bug hit by poll-list.

view this post on Zulip Alex Crichton (Sep 29 2023 at 22:09):

sorry only just now saw this :(

view this post on Zulip Alex Crichton (Sep 29 2023 at 22:14):

oh one intention I had with that though is that in theory each repo could specify a custom wit-bindgen version so it's not always required to update every time wit-bindgen is published and move all the repos in lockstep

view this post on Zulip Alex Crichton (Sep 29 2023 at 22:14):

haven't actually tested that path though

Last updated: Oct 23 2024 at 20:03 UTC