Stream: wasmtime

Topic: new release on Monday?


view this post on Zulip Chris Fallin (Apr 02 2021 at 21:49):

Hey all -- on https://github.com/bytecodealliance/wasmtime-go/issues/53 it came up that one of the recent PRs for Mac M1 support is not in our latest release (0.25). It seems we should probably make a new release soon as this might be causing issues for quite a number of folks?

I might suggest planning to release on Monday, after I merge the new-backend transition PR (assuming no fuzz issues come in over the weekend). Thoughts?

Is this planned? Is this something that would be helpful for me to add and PR?

view this post on Zulip Chris Fallin (Apr 02 2021 at 21:51):

@Dan Gohman @Alex Crichton @fitzgen (he/him) @Peter Huene any other features or considerations re: making a new release?

(I'm happy to volunteer to cut a release this time -- haven't done it before...)

view this post on Zulip Dan Gohman (Apr 02 2021 at 21:52):

@Chris Fallin ship it! :ship:

view this post on Zulip Chris Fallin (Apr 02 2021 at 21:52):

OK cool, will do this on Monday just after merging the new-backend PR

view this post on Zulip Peter Huene (Apr 02 2021 at 21:52):

I have a minor fix I'd like to get up in just a few minutes

view this post on Zulip Peter Huene (Apr 02 2021 at 21:53):

only affects the uffd feature enabled

view this post on Zulip Alex Crichton (Apr 02 2021 at 21:53):

A release seems fine but we wouldn't necessarily fix that issue b/c we don't have CI building releases for aarch64 macbooks

view this post on Zulip Chris Fallin (Apr 02 2021 at 21:53):

ah, right, yeah I don't know how the linked (graphql-node?) thing gets its binaries, maybe it builds from crates.io?

view this post on Zulip fitzgen (he/him) (Apr 02 2021 at 21:53):

it would fix it for people using the embedding API

view this post on Zulip Chris Fallin (Apr 02 2021 at 21:55):

alright cool, I might ping one of you on Monday morning if any issues come up with publishing crates :-)

view this post on Zulip Chris Fallin (Apr 05 2021 at 17:29):

https://github.com/bytecodealliance/wasmtime/pull/2805 for whoever wants to review!

This PR bumps versions of all crates (Wasmtime to 0.26.0, Cranelift to 0.73.0) and adds release notes. Please let me know if I missed any important PRs or got the descriptions wrong on any of the r...

view this post on Zulip Chris Fallin (Apr 05 2021 at 17:29):

Please do let me know if I've missed anything in the release notes as well

view this post on Zulip Chris Fallin (Apr 05 2021 at 19:02):

It seems I'm not an owner of any of the crates; @Alex Crichton @fitzgen (he/him) @Dan Gohman would one of you mind adding me to the right group on crates.io?

view this post on Zulip Alex Crichton (Apr 05 2021 at 19:03):

done!

view this post on Zulip Chris Fallin (Apr 05 2021 at 19:04):

Thanks!

view this post on Zulip Chris Fallin (Apr 05 2021 at 19:04):

Somewhat odd error though: "error: failed to invite owners to crate peepmatic-traits: api errors (status 200 OK): team members don't have permission to modify owners"

view this post on Zulip Chris Fallin (Apr 05 2021 at 19:06):

Related question: I just pushed a tag (v0.26.0) to the repo; do I need to do anything else to make the release w.r.t. GH? (for whatever reason it doesn't appear like the earlier releases on the Releases page)

view this post on Zulip Alex Crichton (Apr 05 2021 at 19:09):

oh you can ignore those messages

view this post on Zulip Alex Crichton (Apr 05 2021 at 19:09):

the script automatically tries to add owners to all crates

view this post on Zulip Chris Fallin (Apr 05 2021 at 19:09):

oh! OK cool

view this post on Zulip Alex Crichton (Apr 05 2021 at 19:09):

the tag is enough for github

view this post on Zulip Alex Crichton (Apr 05 2021 at 19:09):

CI will publish the release when it's finished building

view this post on Zulip Chris Fallin (Apr 05 2021 at 19:12):

Wee, getting 429s, we have too many crates I guess

view this post on Zulip Chris Fallin (Apr 05 2021 at 19:12):

(I remember y'all discussing this, will retry in a bit)

view this post on Zulip Alex Crichton (Apr 05 2021 at 19:15):

yeah I just retry ~5min later

view this post on Zulip Alex Crichton (Apr 05 2021 at 19:16):

sometimes though I have to comment out bits and pieces of the script since it re-attempts to publish which counts towards the 420

view this post on Zulip Alex Crichton (Apr 05 2021 at 19:16):

429*

view this post on Zulip Chris Fallin (Apr 05 2021 at 19:16):

hmm yeah I might try that

view this post on Zulip Chris Fallin (Apr 05 2021 at 19:25):

OK, I think everything is uploaded!


Last updated: Dec 23 2024 at 13:07 UTC