fitzgen (he/him) (May 27 2020 at 18:31): fitzgen (he/him) (May 27 2020 at 18:31):I need access to GlobalFrameInfo (for stack maps) in a libcall, and libcalls are defined in wasmtime-runtime, but GlobalFrameInfo is in the wasmtime-api crate.
Is it reasonable to move GlobalFrameInfo into wasmtime-runtime? Or should I make something akin to GlobalFrameInfo but which only contains stack maps and lives inside wasmtime-runtime?
cc @Alex Crichton
Alex Crichton (May 27 2020 at 18:35):hm so in general I think we have basically 1 global at most for everything
Alex Crichton (May 27 2020 at 18:35):so I'd prefer to avoid having two, one in the api and one in runtime
Alex Crichton (May 27 2020 at 18:36):moving it around seems fine though
Alex Crichton (May 27 2020 at 18:36):ideally though it'd be no global but an explicitly passed in context
Alex Crichton (May 27 2020 at 18:36):the global part is only b/c of Trap::new right now
Alex Crichton (May 27 2020 at 18:36):which takes no contextual argument
Last updated: Oct 23 2024 at 20:03 UTC