Pat Hickey (Apr 16 2020 at 16:20): Pat Hickey (Apr 16 2020 at 16:20):@Andy Wortman just wrote up these docs on lucet's killswitch mechanism: https://github.com/bytecodealliance/lucet/blob/master/docs/src/lucet-runtime/killswitch.md
Pat Hickey (Apr 16 2020 at 16:20):(apropos discussion in the weekly meeting)
Till Schneidereit (Apr 16 2020 at 16:23):cc @Alex Crichton
Alex Crichton (Apr 16 2020 at 20:52):@Pat Hickey this is a pretty cool writeup, thanks for sharing! I think that the support implemented in https://github.com/bytecodealliance/wasmtime/pull/1490 is both sort of orthogonal and related to what y'all are doing.
Alex Crichton (Apr 16 2020 at 20:53):the main thing I see is that SIGALRM isn't needed with a technique like https://github.com/bytecodealliance/wasmtime/pull/1490 (where the wasm code is instrumented), but otherwise it looks like y'all are handling a lot of the complexity with returning from host calls and interrupting that
Alex Crichton (Apr 16 2020 at 20:53):that's something that the PR doesn't try to handle at all and leaves up to the embedder, but what y'all are doing makes sense to me
Pat Hickey (Apr 16 2020 at 20:57):indeed. we have to handle stack overflows in the signal handler as well.
iximeow (Apr 18 2020 at 01:27):one edge lucet doesn't handle at the moment, which i know we (Alex/i) talked about in a wasmtime issue at some point, is recursive calls into a wasm guest. i'm pretty confident that our approach can be extended to handle that in a straightforward manner, we just haven't had that specific use case as a priority quite yet. i'd be super curious if benchmarks show much difference, whenever in the future that's a straightforward comparison :D
Last updated: Nov 22 2024 at 17:03 UTC