heads-up: API change for Module::new() · wasmtime

Stream: wasmtime

Topic: heads-up: API change for Module::new()

Yury Delendik (May 27 2020 at 20:01):

So https://github.com/bytecodealliance/wasmtime/pull/1761 also proposes API change on what we store in Module. It drastically changes how Module::newand Instance::new works: now Instance needs directly hold Storeand Module don't. On bright side, we can send Module across the threads \m/

Disconnects `Store` state fields from `Compiler` by yurydelendik · Pull Request #1761 · bytecodealliance/wasmtime

To make wasmtime more threads friendly, this PR: Moves CodeMemory, VMInterrupts and SignatureRegistry from Compiler CompiledModule holds CodeMemory and GdbJitImageRegistration Store keeps track of...

Dan Gohman (May 27 2020 at 20:07):

While here, can we remove the module field from Instance?

Yury Delendik (May 27 2020 at 21:10):

We will be there after this PR, perhaps :)

Yury Delendik (May 27 2020 at 21:17):

@Dan Gohman yeah, this change will not drive API change. I think removing module requires better CodeMemory ownership management than we have now.

Last updated: Dec 23 2024 at 14:03 UTC