Stream: wasmtime

Topic: file-per-thread-logger in wasmtime-cache

view this post on Zulip Quentin Gliech (Aug 25 2023 at 08:46):

:wave:!
I was looking at my dependency tree and noticed file-per-thread-logger in my dependencies, because of wasmtime-cache. It feels weird that wasmtime-cache would depend on that, so I looked up where it was used and it turns out that it's actually never used!
It would be used here: https://github.com/bytecodealliance/wasmtime/blob/df1502531d437b2105effb990a7caa28796aa985/crates/cache/src/worker.rs#L56
But that function is always called with the init_file_per_thread_logger set to None, and it's not a public function. Am I missing something, or can I try removing this dependency?

view this post on Zulip Quentin Gliech (Aug 25 2023 at 08:52):

Here's a PR: https://github.com/bytecodealliance/wasmtime/pull/6910

Remove the unused `file-per-thread-logger` dependencies from `wasmtime-cache` by sandhose · Pull Request #6910 · bytecodealliance/wasmtime
wasmtime-cache depends on file-per-thread-logger, but never really used it. This removes it from the dependency list.

Last updated: Nov 22 2024 at 16:03 UTC