Andrew Brown (Sep 01 2021 at 19:23): Andrew Brown (Sep 01 2021 at 19:23):@Alex Crichton, @fitzgen (he/him): thinking a bit about @Johnnie Birch's fix in https://github.com/bytecodealliance/wasmtime/pull/3261 and seeing the errors building this for Sightglass, I started getting concerned that the bench-api crate was not being built in Wasmtime's CI?
Andrew Brown (Sep 01 2021 at 19:24):It should be, right? But for some reason the API change (and subsequent compiler error) wasn't caught until we actually built a Sightglass engine (i.e. bench-api)
fitzgen (he/him) (Sep 01 2021 at 19:27):Yeah I was under the impression that it was; could be related to feature resolution and workspaces
Alex Crichton (Sep 01 2021 at 19:35):I'm not sure if it is myself, but if it isn't should be easy enough to add
fitzgen (he/him) (Sep 01 2021 at 19:48):fitzgen (he/him) said:
Yeah I was under the impression that it was; could be related to feature resolution and workspaces
I say this because the bench-api relies on the cranelift feature, but was not previously explicitly enabling it (and also requesting no default features), but things probably just worked in CI anyways because other crates in the workspace were enabling that feature. as soon as we are outside of the workspace, no one else was forcing the cranelift feature on, and so we didn't get those Module::new/etc methods, and therefore the build broke
fitzgen (he/him) (Sep 01 2021 at 19:48):pretty sure that is what was going on
Last updated: Dec 23 2024 at 13:07 UTC