Dan Gohman (Mar 04 2021 at 17:57): Dan Gohman (Mar 04 2021 at 17:57):@Chris Fallin Are you testing Windows locally, or just using CI?
Dan Gohman (Mar 04 2021 at 17:57):Windows symlink support is guarded by a system-wide config flag which is off by default on most Windows desktop installations, but is on by default in CI
Chris Fallin (Mar 04 2021 at 17:58):@Dan Gohman that would explain it -- I'm testing locally on "living room media PC with MinGW slapped on" which is definitely not CI-grade special config
Chris Fallin (Mar 04 2021 at 17:59):/me will google how to enable this -- thanks!
Dan Gohman (Mar 04 2021 at 17:59):That's probably it then. So yeah, we just need to disable those tests
Dan Gohman (Mar 04 2021 at 17:59):It's called "Developer Mode" in the control panel, and it's somewhat invasive, so I think we'd prefer to just disable those tests on Windows for now than to require people to turn that on
Chris Fallin (Mar 04 2021 at 18:01):ah, OK, that makes sense. For now I'll keep the shell-script exclusion but I suppose the proper fix is to add #[cfg(...)] directives in the test suite?
Dan Gohman (Mar 04 2021 at 18:01):In cap-std's unit tests, we have a symlink_supported() utility function which tests whether symlinks are supported and conditionally enables those tests, so another option is to port that to wasmtime.
Chris Fallin (Mar 04 2021 at 18:02):Makes sense. I can create an issue to track this
Dan Gohman (Mar 04 2021 at 18:02):But it's fine with me to just disable the tests for now
Chris Fallin (Mar 04 2021 at 18:05):https://github.com/bytecodealliance/wasmtime/issues/2706
Last updated: Nov 22 2024 at 16:03 UTC