Stream: wasmtime

Topic: VTune testing in CI

Andrew Brown (Aug 29 2024 at 16:55):

Long ago, when VTune was first added, I thought it would be a good idea to test that the VTune integration still works in a CI test. I'm going to describe how that could be done and I'm looking for the answer to "is it worth it?"

Here's how I would do it:

• I've already created a GitHub action to install VTune on Linux runners (install-vtune-action); that action would be added to a CI job (a new job? test?)
• I would add a CLI test to run a command that boils down to vtune ... wasmtime --profile vtune ... and capture the results
• But, to not fail where VTune is not installed, this test would first check that vtune is available on the path somehow (e.g., the which crate); if it's not, just pass the test unconditionally
• If we can in fact run VTune, the test would do some string matching to check that VTune is getting the right symbol information as well as checking the status code to ensure none of this fails.

Is it worth it?

Andrew Brown (Aug 29 2024 at 16:55):

cc: @fitzgen (he/him), @Alex Crichton

fitzgen (he/him) (Aug 29 2024 at 16:59):

sounds good to me

minor nitpick: rather than adding a dep on the which crate, I'd just try doing vtune --help or something like that to see if it is installed

Andrew Brown (Aug 29 2024 at 17:14):

yeah, that's better; just a heads up, though, somehow which is transitively included in the dep tree?

Last updated: Nov 22 2024 at 16:03 UTC