Renaming `master` to `main` · wasmtime

Stream: wasmtime

Topic: Renaming `master` to `main`

Alex Crichton (Jun 25 2020 at 15:07):

Wanted to give everyone a heads up that I'm going to be tackling https://github.com/bytecodealliance/wasmtime/issues/1881 today which is to rename wasmtime's master branch to main. I'll be going through all PRs and manually editing their target branch so they all stay open, but otherwise folks will need to update their local checkouts because I'll be deleting the master branch after main is in place.

Change default branch name · Issue #1881 · bytecodealliance/wasmtime

As a policy, the Bytecode Alliance is changing the default branch names in all repositories. We would like for all projects to change the default to main by June 26. (We mention June 26th because t...

Alex Crichton (Jun 25 2020 at 15:07):

Procedurally what I plan to do later this afternoon is:

Push a new main branch which is the same as master

Alex Crichton (Jun 25 2020 at 15:08):

make a PR to main which updates all CI configuration, let that merge
Update the default branch of the repo
Update all PRs to target main instead of master
Make sure master and main are the same thing (other than the CI commit)
Delete the master branch

Alex Crichton (Jun 25 2020 at 15:10):

I may also take this opportunity to clean up the branches we have in the wasmtime repo...

Till Schneidereit (Jun 25 2020 at 15:57):

Thank you for doing this! :heart:

Peter Huene (Jun 25 2020 at 18:53):

fyi, there are master branch links in the README.md that will need updating.

Peter Huene (Jun 25 2020 at 18:54):

and a few other places

Alex Crichton (Jun 25 2020 at 18:58):

ok this should now be done! - https://github.com/bytecodealliance/wasmtime/pull/1924

Rename the `master` branch to `main` by alexcrichton · Pull Request #1924 · bytecodealliance/wasmtime

This PR is against a branch called main Internally all docs/CI/etc is updated The default branch of the repo is now main All active PRs have been updated to retarget main Closes #1914

Alex Crichton (Jun 25 2020 at 18:59):

biggest fallout appears to be that CI will not run unless folks rebase their PR

Alex Crichton (Jun 25 2020 at 19:00):

CI was not retriggered when switching branches

Alex Crichton (Jun 25 2020 at 19:00):

but if folks push it won't do anything unless they rebase

Peter Huene (Jun 25 2020 at 19:06):

Wrong link in your PR, by the way, accidentally closed https://github.com/bytecodealliance/wasmtime/pull/1914 :)

When targeting musl, libunwind is used for the __register_frame implementation. Unlike when targeting libgcc which expects an entire frame table, the libunwind implementation expects a single FDE. ...

Alex Crichton (Jun 25 2020 at 19:06):

gah sorry about that

Josh Triplett (Jun 26 2020 at 15:54):

@Alex Crichton What process did you use to update PRs to target main?

Alex Crichton (Jun 26 2020 at 15:54):

There's an "edit" button at the top of each PR

Alex Crichton (Jun 26 2020 at 15:54):

where after you hit it you can update the base branch

Alex Crichton (Jun 26 2020 at 15:54):

I did that manually

Josh Triplett (Jun 26 2020 at 15:54):

Ah, perfect, thank you.

Josh Triplett (Jun 27 2020 at 09:49):

Rename done for WAMR. Took a little time to get all the branch references fixed, including those for other repositories.

Last updated: Nov 22 2024 at 17:03 UTC