As a heads-up to everyone, I'm thinking of publishing Wasmtime 0.13 crates soon
can we bump wiggle & children versions to 0.13 as part of this process, and publish them as part of the wasmtime publish?
ive never done a wasmtime publish so idk whether this is something that needs to be added to various build scripts.
The scripts... need some work in any case.
As an update here, I'm still working on getting this release out.
Anything I can do to help?
I'll let you know. The script takes a long time to run and even with 20 second pauses between cargo publish invocations, it still fails sometimes due to the server not updating the index fast enough.
Ok, the circular dependency between wiggle and wiggle-test is still there. @Pat Hickey @Jakub Konka @Alex Crichton could someone take a look at this?
will do!
i suspect we have to move wiggle's tests inside that crate, rather than under wiggle
is there a reason that more subdirectories arent included in the crate-root Cargo.toml workspace members?
I had to add crates/wiggle/test-helpers
in addition to the crates/wiggle
thats already there in order to be able to run cargo test -p wiggle-test
cc @Alex Crichton
Should I avoid merging stuff in the meantime?
@Dan Gohman I think you can just remove the verseion from the wiggle-test dependency
as in, just wiggle-test = { path = "..." }
that should avoid needing it to exist on crates.io
https://github.com/bytecodealliance/wasmtime/pull/1445
too late, fixed it the other way
somethings borked in wasi-common
package wasi-common v0.15.0 (/build/wasmtime/target/package/wasi-common-0.15.0)
specifies that it links to wasi-common-15
but does not have a custom build script
@Alex Crichton
I changed it from -14 to 15 assuming that it's meant to follow the crate version
but it's the same error either way
@Dan Gohman hm there's a build.rs
file there right?
at crates/wasi-common/Cargo.toml
?
er, crates/wasi-common/build.rs
I mean
yes
I uploaded by 0.15 branch so you can see what I have. Run cargo publish --manifest-path crates/wasi-common/Cargo.toml --dry-run
and you should see the error
@Dan Gohman oh you may need to edit include
to include build.rs
that seems to have worked, thanks!
error: failed to run custom build command for wasmtime-wasi v0.15.0 (/build/wasmtime/target/package/wasmtime-wasi-0.15.0)
Caused by:
process didn't exit successfully: /build/wasmtime/target/package/wasmtime-wasi-0.15.0/target/debug/build/wasmtime-wasi-7cfcb026f8ac69bd/build-script-build
(exit code: 101)
--- stderr
thread 'main' panicked at 'called Result::unwrap()
on an Err
value: NotPresent', build.rs:2:21
note: run with RUST_BACKTRACE=1
environment variable to display a backtrace
oh, I need to update the env var too.
Ok, 0.15 is on crates.io!
Excellent. I'll publish the .NET NuGet package since it has the API rewrite.
are we going to create a tagged release for 0.15.0?
ah i assume once we merge in the version bump PR.
Oh, the publish script creates a tag but doesn't push it
How do I push a single git tag?
git push <tagname>
fatal: 'v0.15.0' does not appear to be a git repository
i assume it's pointing to the commit in PR
Yeah
Ok, I'm not sure what's going on with the dev
tag, but when I deleted by local copy, then git push --tags worked.
Last updated: Dec 23 2024 at 14:03 UTC