Dan Gohman (Mar 24 2020 at 22:35): Dan Gohman (Mar 24 2020 at 22:35):As a heads-up to everyone, I'm thinking of publishing Wasmtime 0.13 crates soon
Pat Hickey (Mar 24 2020 at 23:06):can we bump wiggle & children versions to 0.13 as part of this process, and publish them as part of the wasmtime publish?
Pat Hickey (Mar 24 2020 at 23:07):ive never done a wasmtime publish so idk whether this is something that needs to be added to various build scripts.
Dan Gohman (Mar 24 2020 at 23:11):The scripts... need some work in any case.
Dan Gohman (Mar 31 2020 at 15:41):As an update here, I'm still working on getting this release out.
Pat Hickey (Mar 31 2020 at 16:17):Anything I can do to help?
Dan Gohman (Mar 31 2020 at 17:06):I'll let you know. The script takes a long time to run and even with 20 second pauses between cargo publish invocations, it still fails sometimes due to the server not updating the index fast enough.
Dan Gohman (Mar 31 2020 at 17:09):Ok, the circular dependency between wiggle and wiggle-test is still there. @Pat Hickey @Jakub Konka @Alex Crichton could someone take a look at this?
Pat Hickey (Mar 31 2020 at 17:11):will do!
Pat Hickey (Mar 31 2020 at 17:12):i suspect we have to move wiggle's tests inside that crate, rather than under wiggle
Pat Hickey (Mar 31 2020 at 17:20):is there a reason that more subdirectories arent included in the crate-root Cargo.toml workspace members?
Pat Hickey (Mar 31 2020 at 17:21):I had to add crates/wiggle/test-helpers in addition to the crates/wiggle thats already there in order to be able to run cargo test -p wiggle-test
Pat Hickey (Mar 31 2020 at 17:21):cc @Alex Crichton
Andrew Brown (Mar 31 2020 at 17:33):Should I avoid merging stuff in the meantime?
Alex Crichton (Mar 31 2020 at 17:39):@Dan Gohman I think you can just remove the verseion from the wiggle-test dependency
Alex Crichton (Mar 31 2020 at 17:39):as in, just wiggle-test = { path = "..." }
Alex Crichton (Mar 31 2020 at 17:39):that should avoid needing it to exist on crates.io
Pat Hickey (Mar 31 2020 at 17:40):https://github.com/bytecodealliance/wasmtime/pull/1445
Pat Hickey (Mar 31 2020 at 17:40):too late, fixed it the other way
Dan Gohman (Mar 31 2020 at 18:21):somethings borked in wasi-common
Dan Gohman (Mar 31 2020 at 18:21):package wasi-common v0.15.0 (/build/wasmtime/target/package/wasi-common-0.15.0) specifies that it links to wasi-common-15 but does not have a custom build script
@Alex Crichton
Dan Gohman (Mar 31 2020 at 18:24):I changed it from -14 to 15 assuming that it's meant to follow the crate version
Dan Gohman (Mar 31 2020 at 18:25):but it's the same error either way
Alex Crichton (Mar 31 2020 at 18:30):@Dan Gohman hm there's a build.rs file there right?
Alex Crichton (Mar 31 2020 at 18:30):at crates/wasi-common/Cargo.toml?
Alex Crichton (Mar 31 2020 at 18:30):er, crates/wasi-common/build.rs I mean
Dan Gohman (Mar 31 2020 at 18:30):yes
Dan Gohman (Mar 31 2020 at 18:31):I uploaded by 0.15 branch so you can see what I have. Run cargo publish --manifest-path crates/wasi-common/Cargo.toml --dry-run and you should see the error
Alex Crichton (Mar 31 2020 at 18:32):@Dan Gohman oh you may need to edit include
Alex Crichton (Mar 31 2020 at 18:32):to include build.rs
Dan Gohman (Mar 31 2020 at 18:34):that seems to have worked, thanks!
Dan Gohman (Mar 31 2020 at 18:49):error: failed to run custom build command for wasmtime-wasi v0.15.0 (/build/wasmtime/target/package/wasmtime-wasi-0.15.0)
Caused by:
process didn't exit successfully: /build/wasmtime/target/package/wasmtime-wasi-0.15.0/target/debug/build/wasmtime-wasi-7cfcb026f8ac69bd/build-script-build (exit code: 101)
--- stderr
thread 'main' panicked at 'called Result::unwrap() on an Err value: NotPresent', build.rs:2:21
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
Dan Gohman (Mar 31 2020 at 18:50):oh, I need to update the env var too.
Dan Gohman (Mar 31 2020 at 19:14):Ok, 0.15 is on crates.io!
Peter Huene (Mar 31 2020 at 19:25):Excellent. I'll publish the .NET NuGet package since it has the API rewrite.
Peter Huene (Mar 31 2020 at 19:27):are we going to create a tagged release for 0.15.0?
Peter Huene (Mar 31 2020 at 19:28):ah i assume once we merge in the version bump PR.
Dan Gohman (Mar 31 2020 at 19:29):Oh, the publish script creates a tag but doesn't push it
Dan Gohman (Mar 31 2020 at 19:29):How do I push a single git tag?
Pat Hickey (Mar 31 2020 at 19:30):git push <tagname>
Dan Gohman (Mar 31 2020 at 19:33):fatal: 'v0.15.0' does not appear to be a git repository
Peter Huene (Mar 31 2020 at 19:33):i assume it's pointing to the commit in PR
Dan Gohman (Mar 31 2020 at 19:34):Yeah
Dan Gohman (Mar 31 2020 at 19:39):Ok, I'm not sure what's going on with the dev tag, but when I deleted by local copy, then git push --tags worked.
Last updated: Nov 22 2024 at 16:03 UTC