Chris Fallin (Aug 20 2024 at 19:04): Chris Fallin (Aug 20 2024 at 19:04):Should wasmtime serve -W max-memory-size=... work as for wasmtime run? I see that there is some plumbing that shares all the "common" run options, but I'm hitting an issue where this doesn't seem to be actually taking effect (cc @Alex Crichton @Dan Gohman )
Alex Crichton (Aug 20 2024 at 19:04):it should in theory yeah, but I wouldn't be entirely surprised if there was a divergence
Chris Fallin (Aug 20 2024 at 19:04):cool, I'll chase it down
Alex Crichton (Aug 20 2024 at 19:04):one important difference between run/serve is that serve uses the pooling allocator by default
Alex Crichton (Aug 20 2024 at 19:04):but that should be unrelated to max-memory-size
Chris Fallin (Aug 20 2024 at 19:04):indeed
Alex Crichton (Aug 20 2024 at 19:05):it looks like both run/serve are using StoreLimits though and are calling the same method in src/common.rs, so unsure :(
Chris Fallin (Aug 20 2024 at 19:09):ah, well, the issue went away with a newer Wasmtime (I had v20 in my PATH by default)
Chris Fallin (Aug 20 2024 at 19:10):it was still a documented option on that version but... all's well now shrug
Notification Bot (Aug 20 2024 at 19:10):Chris Fallin has marked this topic as resolved.
Alex Crichton (Aug 20 2024 at 19:15):it might have been a refactoring between now-and-then that fixed this issue perhaps?
Chris Fallin (Aug 20 2024 at 19:16):likely, yeah, not going to try to chase down exactly when it started working as long as it works now!
Last updated: Dec 23 2024 at 13:07 UTC