Cheng Shao (Mar 10 2022 at 13:23): Cheng Shao (Mar 10 2022 at 13:23):Hi all, where should I be looking at if I want to add embedder-specified hooks to report each wasm function call? The motivation is logging libc allocator calls to detect use-after-free and such
fitzgen (he/him) (Mar 10 2022 at 18:02):this is not a built-in feature of Wasmtime, but I believe that wasm-opt allows instrumenting Wasm modules to insert calls to imported tracing functions like this, so you give it a Wasm module and you get out an instrumented Wasm module
Cheng Shao (Mar 10 2022 at 18:28):we already instrument cranelift IR for fuels right? so i'm just wondering if i can add similar logic but for wasm function calls (and expose that to c api too)
fitzgen (he/him) (Mar 10 2022 at 18:40):it is certainly technically possible; whether we would want to implement and maintain it feels like something that an RFC would decide
fitzgen (he/him) (Mar 10 2022 at 18:41):there is also the call_hook for tracing the transfer of control between the host and wasm, fwiw
Cheng Shao (Mar 10 2022 at 18:44):i see, thx for answering!
Chris Fallin (Mar 10 2022 at 18:45):@Cheng Shao a distinction I would make that seems like it could be useful in deciding things like this (especially wrt other instrumentation cases like fuel): if a code-instrumentation technique needs to interact closely with the runtime, then it makes sense to put the implementation in Wasmtime itself. For example, fuel and epoch interruption need to call special hooks (libcalls) in the runtime, and there is a certain protocol (eg for epochs, the hook returns the new epoch). In a sense, the instrumentation serves the implementation of a Wasmtime-internal feature. But here the behavior we want is just to call an external hook, so there is (i) little coupling with Wasmtime's internals, and (ii) lots of coupling with the particular needs of your instrumentation
Chris Fallin (Mar 10 2022 at 18:45):that feels like the most important bit to me: coupling with wasmtime vs coupling with user's particular use-case
Chris Fallin (Mar 10 2022 at 18:46):but, as fitzgen says, we could definitely discuss further in an RFC if you want to propose an API for this!
Cheng Shao (Mar 10 2022 at 18:47):yes, that distinction makes a lot of sense
Notification Bot (Mar 10 2022 at 18:48):Cheng Shao has marked this topic as resolved.
Last updated: Dec 23 2024 at 13:07 UTC