✔ async_stack_size in c-api · wasmtime

Stream: wasmtime

Topic: ✔ async_stack_size in c-api

Greg Roseberry (Jul 24 2023 at 17:49):

Hello, first time contributor here. I would like to expose async_stack_size in the C API so that wasmtime-go can configure its stack sizes.
I made a PR in a fork, if someone could take a look I would be grateful (it's a small PR). If it looks OK I'll make a PR against the main repo!
https://github.com/guregu/wasmtime/pull/1

c-api: Expose async_stack_size configuration by guregu · Pull Request #1 · guregu/wasmtime

Adds wasm_config_async_stack_size_set to C API. Motivation: I want to set the stack size in wasmtime-go, but max_wasm_stack is limited by async_stack_size, so we need to set this too.

Pat Hickey (Jul 24 2023 at 17:52):

lgtm, please send it upstream

Greg Roseberry (Jul 24 2023 at 17:53):

Thanks, will do!

Greg Roseberry (Jul 24 2023 at 17:57):

sent PR against upstream here: https://github.com/bytecodealliance/wasmtime/pull/6762 :ok_signal:

c-api: Expose async_stack_size configuration by guregu · Pull Request #6762 · bytecodealliance/wasmtime

Adds wasm_config_async_stack_size_set to C API. Also updates the stack-related comments in config.h to match the latest Rust ones. Motivation: I want to set the stack size in wasmtime-go, but max_w...

Notification Bot (Jul 31 2023 at 06:10):

Greg Roseberry has marked this topic as resolved.

Last updated: Nov 22 2024 at 17:03 UTC