Alex Crichton (Feb 24 2020 at 18:12): Alex Crichton (Feb 24 2020 at 18:12):oh @fitzgen
Alex Crichton (Feb 24 2020 at 18:12):er, @Nick Fitzgerald I just pushed up a new commit to the annotations pr
Alex Crichton (Feb 24 2020 at 18:12):which implements a more "register this" style of API
fitzgen (he/him) (Feb 24 2020 at 18:13):cool, almost done reviewing the previous bits
Alex Crichton (Feb 24 2020 at 18:13):sorry didn't realize you were in the middle of reviewing
fitzgen (he/him) (Feb 24 2020 at 18:13):no worries :)
Alex Crichton (Feb 24 2020 at 18:13):you may want to start by reading Parser::register_annotation
Alex Crichton (Feb 24 2020 at 18:13):followed by the docs on ast::annotation macro
Alex Crichton (Feb 24 2020 at 18:13):er, the docs in those two places
Alex Crichton (Feb 24 2020 at 18:13):that should provide context for most of the other changes
fitzgen (he/him) (Feb 24 2020 at 18:13):is it a new commit that I can read in isolation?
Alex Crichton (Feb 24 2020 at 18:15):@Nick Fitzgerald should be yeah
Last updated: Nov 22 2024 at 16:03 UTC