Stream: cranelift

Topic: trap collection in cranelift-faerie

view this post on Zulip acfoltzer (Mar 25 2020 at 23:27):

Hey folks, I notice that Backend::define_function() now takes a TrapSink as an argument, meaning we can no longer just ask cranelift-faerie to use its built-in sink. I was wondering if there's a recommended migration path for this, or if we need to be rolling our own trap sink now in Lucet?

view this post on Zulip Dan Gohman (Mar 25 2020 at 23:30):

@Nathan Froyd ^

view this post on Zulip Dan Gohman (Mar 25 2020 at 23:31):

Context: https://github.com/bytecodealliance/wasmtime/pull/1389

change Module::define_function to take TrapSink instances by froydnj · Pull Request #1389 · bytecodealliance/wasmtime
Experience with the define_function API has shown that returning borrowed slices of TrapSite is not ideal: the returned slice represents a borrow on the entire Module, which makes calling back into...

view this post on Zulip acfoltzer (Mar 25 2020 at 23:33):

aha, thank you for that pointer. I knew things were afoot but my focus has been more on our internal stuff lately

view this post on Zulip Pat Hickey (Mar 26 2020 at 02:36):

yeah sorry i could have told you all about this one but i was out this afternoon :)

Last updated: Nov 22 2024 at 17:03 UTC