Chris Fallin (Apr 17 2020 at 17:18): Chris Fallin (Apr 17 2020 at 17:18):A stupid question (I've been told there is no such thing, but this may disprove): what's the standard etiquette on wasmtime/cranelift repos for merging when a review requests relatively minor changes but approves? Wait for one last look, or just merge when green? I've been on projects that go both ways...
Dan Gohman (Apr 17 2020 at 17:20):Just merge when green in that case.
Dan Gohman (Apr 17 2020 at 17:21):Approval with minor changes requested means "I trust these are straightforward that I don't feel another round of review is required"
Chris Fallin (Apr 17 2020 at 17:21):Thanks!
Last updated: Nov 22 2024 at 17:03 UTC