Stream: cranelift

Topic: emit_small_memory_copy ignores alignment


view this post on Zulip Veverak (Dec 03 2021 at 13:05):

cranelift_frontend::FunctionBuilder::emit_small_memory_copy(documentation) takes the arguments dest_align and src_align, which it uses only for an assertion and then ignores. It chooses an access size which may be larger than the alignment and calls flags.set_aligned(); and proceeds to doing unaligned memory access. This seems to be a mistake.

view this post on Zulip bjorn3 (Dec 03 2021 at 13:10):

Can you open an issue?

view this post on Zulip Veverak (Dec 03 2021 at 13:17):

I don't have a Github account, so unfortunately that excludes me from the issue tracker. I might create an account that I use only to contribute to Cranelift, but I'm very reluctant after all the bad news about Github.

view this post on Zulip bjorn3 (Dec 03 2021 at 13:35):

No problem. Can I create an issue and copy paste your message?

view this post on Zulip Veverak (Dec 03 2021 at 13:52):

Of course you can. Thank you.

view this post on Zulip bjorn3 (Dec 03 2021 at 13:54):

Done: https://github.com/bytecodealliance/wasmtime/issues/3583

cranelift_frontend::FunctionBuilder::emit_small_memory_copy(documentation) takes the arguments dest_align and src_align, which it uses only for an assertion and then ignores. It chooses an access s...

Last updated: Oct 23 2024 at 20:03 UTC