Yury Delendik (Jun 03 2020 at 16:06): Yury Delendik (Jun 03 2020 at 16:06):cl-object and cl-faerie produce object files , which one is here to stay?
Pat Hickey (Jun 03 2020 at 16:09):object is generally more capable than faerie, so i think thats the best bet to go forward. when we last talked about this, fastly had just switched from using cl-faerie to cl-object in prod, and we wanted to keep faerie in tree for a little longer in case we needed to revert that change while we figured out any object bugs.
Pat Hickey (Jun 03 2020 at 16:10):my preference would be to keep cl-faerie in tree for another month or two, but maybe its appropriate to start marking it as deprecated and going away soon? if you're planning any major renovations to cl-module / cl-object that would make it hard to carry faerie along, then we can drop it sooner.
Yury Delendik (Jun 03 2020 at 16:11):Nice. Can we mark them or one of them somehow to identify that we made such decision?
Pat Hickey (Jun 03 2020 at 16:12):yes, we ought to, im not sure the best way to actually do so though.
Yury Delendik (Jun 03 2020 at 16:12):/me remembered the conversation but do not remember which one
Pat Hickey (Jun 03 2020 at 16:13):https://doc.rust-lang.org/edition-guide/rust-2018/the-compiler/an-attribute-for-deprecation.html we could mark the FaerieBuilder::new function with the deprecated attribute
Yury Delendik (Jun 03 2020 at 16:13):/me did look at opened issues, READMEs and Cargo.toml
Pat Hickey (Jun 03 2020 at 16:14):and note it in the readme as well.
Pat Hickey (Jun 03 2020 at 16:14):i believe we discussed it verbally in one of the cranelift or wasmtime zoom meetings, but im not aware of anywhere we wrote it down.
Pat Hickey (Jun 03 2020 at 23:05):im prepping a PR announcing the planned deprecation of cranelift-faerie. I figure 60 days notice is sufficient, so we can say that we intend to remove this crate from the tree on or after Aug 3, 2020. does that seem reasonable @Dan Gohman ?
Dan Gohman (Jun 03 2020 at 23:09):Sounds good to me.
Dan Gohman (Jun 03 2020 at 23:12):according to crates.io reverse-deps the only things using cranelift-faerie are lucetc and a programming-language project called graviton
Dan Gohman (Jun 03 2020 at 23:13):but graviton recently deleted large parts of their code and plan to rewrite it
Pat Hickey (Jun 03 2020 at 23:18):cool. and i think the design of cranelift-module makes it really straightforward to ask users to switch to cranelift-object
Pat Hickey (Jun 03 2020 at 23:18):thanks for looking into the reverse dep search, i had not thought of that.
Pat Hickey (Jun 03 2020 at 23:22):https://github.com/bytecodealliance/wasmtime/pull/1816
Pat Hickey (Jun 03 2020 at 23:23):i'll open an issue on graviton
Dan Gohman (Jun 03 2020 at 23:29):The code for cranelift-object isn't even in the tree anymore, as it was deleted along with a bunch of other stuff
Dan Gohman (Jun 03 2020 at 23:29):er, cranelift-faerie
Pat Hickey (Jun 03 2020 at 23:30):ah, cool. well, that should make the transition easy. I filed an issue on their bug tracker to be polite, but im def not going to sweat it :)
Last updated: Nov 22 2024 at 16:03 UTC