cl-object and cl-faerie produce object files , which one is here to stay?
object is generally more capable than faerie, so i think thats the best bet to go forward. when we last talked about this, fastly had just switched from using cl-faerie to cl-object in prod, and we wanted to keep faerie in tree for a little longer in case we needed to revert that change while we figured out any object bugs.
my preference would be to keep cl-faerie in tree for another month or two, but maybe its appropriate to start marking it as deprecated and going away soon? if you're planning any major renovations to cl-module / cl-object that would make it hard to carry faerie along, then we can drop it sooner.
Nice. Can we mark them or one of them somehow to identify that we made such decision?
yes, we ought to, im not sure the best way to actually do so though.
/me remembered the conversation but do not remember which one
https://doc.rust-lang.org/edition-guide/rust-2018/the-compiler/an-attribute-for-deprecation.html we could mark the FaerieBuilder::new function with the deprecated attribute
/me did look at opened issues, READMEs and Cargo.toml
and note it in the readme as well.
i believe we discussed it verbally in one of the cranelift or wasmtime zoom meetings, but im not aware of anywhere we wrote it down.
im prepping a PR announcing the planned deprecation of cranelift-faerie. I figure 60 days notice is sufficient, so we can say that we intend to remove this crate from the tree on or after Aug 3, 2020. does that seem reasonable @Dan Gohman ?
Sounds good to me.
according to crates.io reverse-deps the only things using cranelift-faerie are lucetc and a programming-language project called graviton
but graviton recently deleted large parts of their code and plan to rewrite it
cool. and i think the design of cranelift-module makes it really straightforward to ask users to switch to cranelift-object
thanks for looking into the reverse dep search, i had not thought of that.
https://github.com/bytecodealliance/wasmtime/pull/1816
i'll open an issue on graviton
The code for cranelift-object isn't even in the tree anymore, as it was deleted along with a bunch of other stuff
er, cranelift-faerie
ah, cool. well, that should make the transition easy. I filed an issue on their bug tracker to be polite, but im def not going to sweat it :)
Last updated: Dec 23 2024 at 12:05 UTC