Carlo Kok (Jun 06 2020 at 14:16): Carlo Kok (Jun 06 2020 at 14:16):Is there any support for comdat in Cranelift?
bjorn3 (Jun 06 2020 at 14:32):No. If you want to add support, you will need to implement it in object first.
Carlo Kok (Jul 20 2020 at 18:05):so https://github.com/gimli-rs/object/pull/243 supports COMDAT now.
Carlo Kok (Jul 20 2020 at 18:42):so to get back to this
Carlo Kok (Jul 20 2020 at 18:42):should I create an issue for this first, wait for the oke, then a PR?
Carlo Kok (Jul 20 2020 at 18:58):https://github.com/bytecodealliance/wasmtime/issues/2048
Till Schneidereit (Jul 21 2020 at 10:04):@Carlo Kok I think that mainly depends on if it's an easy fix or not, and whether you anticipate any disagreement on the approach
Till Schneidereit (Jul 21 2020 at 10:27):ah, I misread, and now see that you did open the issue. I don't know how much work the implementation is here, but if it's not too much, I'd suggest starting on that now, given that what you describe as the approach does seem reasonable (to me, lacking domain expertise!)
Carlo Kok (Aug 22 2020 at 05:10):anyone able to help me with the design for comdat within cranelift? Comdat itself is essentially 1 symbol, with a mode (comdat mode), tied to other symbols. Where a symbol can be either a global var or a global function.
Carlo Kok (Aug 22 2020 at 05:10):I'm having a bit of trouble with the right design for this
Carlo Kok (Sep 09 2020 at 11:49):Anyone feel like commenting on this https://github.com/bytecodealliance/wasmtime/issues/2048#issuecomment-669041583 ? I'm having a bit of trouble with the design for this feature.
Last updated: Dec 23 2024 at 12:05 UTC