Stream: cranelift

Topic: aarch64 sign extension

view this post on Zulip bjorn3 (Nov 20 2021 at 14:36):

@Alex Crichton https://github.com/bytecodealliance/wasmtime/pull/3538 removed sign extension during lowering stating that the payload is already sign extended. I don't think this is true as per https://github.com/bytecodealliance/wasmtime/pull/3538#discussion_r750774769.

aarch64: Remove manual sign extension in lowering by alexcrichton · Pull Request #3538 · bytecodealliance/wasmtime
Currently the lowering for iconst will sign-extend the payload value of the iconst instruction itself, but the payload is already sign-extended to this isn't necessary. This commit removes the ...
aarch64: Remove manual sign extension in lowering by alexcrichton · Pull Request #3538 · bytecodealliance/wasmtime
Currently the lowering for iconst will sign-extend the payload value of the iconst instruction itself, but the payload is already sign-extended to this isn't necessary. This commit removes the ...

view this post on Zulip Alex Crichton (Nov 22 2021 at 16:26):

Ah this is ok regardless, the iconst lowering was actually dead code so it doesn't really matter anyway. I'm sure I'll hit this when trying to use various bits and pieces with future lowerings.

Last updated: Oct 23 2024 at 20:03 UTC