Stream: cranelift

Topic: Reproducible builds


view this post on Zulip Josh Triplett (Dec 18 2019 at 08:16):

I found a couple of sources of non-reproducible builds in cranelift. I'm currently working on fixing those; expect a couple of PRs soonish.

view this post on Zulip Josh Triplett (Dec 18 2019 at 09:48):

Nevermind, it looks like I rediscovered the work already done in cranelift commit 497b4e1ca1d33dfd54314366d8e3a27a9fea225f, which just isn't in current wasmtime. Would it be much trouble to do a cranelift release so wasmtime can depend on it?

view this post on Zulip Benjamin Bouvier (Dec 18 2019 at 10:06):

Yes, it's a good time, I'll do it! For what it's worth, I've added CI checks that the generated meta code is (very likely to be) deterministic, so we don't run into this ever again (this messes up with caching in build systems).

view this post on Zulip Benjamin Bouvier (Dec 18 2019 at 11:39):

@Dan Gohman I'm not an owner of all the cranelift crates, so I did a partial release, sorry. Can you add Yury and me as owners of cranelift-codegen-shared please? Thanks!

view this post on Zulip Dan Gohman (Dec 18 2019 at 15:28):

Done -- log into crates.io and check your Owner Invites

view this post on Zulip Benjamin Bouvier (Dec 18 2019 at 15:29):

Thank you!

view this post on Zulip Benjamin Bouvier (Dec 18 2019 at 15:46):

And it's done! 0.52.0 is now published and live.

view this post on Zulip Andrew Brown (Dec 18 2019 at 17:23):

I marked the PR bringing 0.52.0 into wasmtime as ready for review if anyone has time: https://github.com/bytecodealliance/wasmtime/pull/710

This PR is a bit premature (since Cranelift v0.52.0 has not yet been published) but as I attempt to get SIMD spec tests working I need changes like these to build my locally-changing copy of Cranel...

view this post on Zulip Sean Stangl (Dec 18 2019 at 17:25):

Oh, into wasmtime, that's not my territory. I just saw "Andrew Brown" and jumped :)

view this post on Zulip Andrew Brown (Dec 18 2019 at 17:30):

@Sean Stangl there's an easy one for and_not in cranelift coming your way!

view this post on Zulip Dan Gohman (Dec 18 2019 at 21:23):

Unclear why the tests fail on beta :-(


Last updated: Dec 23 2024 at 13:07 UTC