Josh Triplett (Dec 18 2019 at 08:16): Josh Triplett (Dec 18 2019 at 08:16):I found a couple of sources of non-reproducible builds in cranelift. I'm currently working on fixing those; expect a couple of PRs soonish.
Josh Triplett (Dec 18 2019 at 09:48):Nevermind, it looks like I rediscovered the work already done in cranelift commit 497b4e1ca1d33dfd54314366d8e3a27a9fea225f, which just isn't in current wasmtime. Would it be much trouble to do a cranelift release so wasmtime can depend on it?
Benjamin Bouvier (Dec 18 2019 at 10:06):Yes, it's a good time, I'll do it! For what it's worth, I've added CI checks that the generated meta code is (very likely to be) deterministic, so we don't run into this ever again (this messes up with caching in build systems).
Benjamin Bouvier (Dec 18 2019 at 11:39):@Dan Gohman I'm not an owner of all the cranelift crates, so I did a partial release, sorry. Can you add Yury and me as owners of cranelift-codegen-shared please? Thanks!
Dan Gohman (Dec 18 2019 at 15:28):Done -- log into crates.io and check your Owner Invites
Benjamin Bouvier (Dec 18 2019 at 15:29):Thank you!
Benjamin Bouvier (Dec 18 2019 at 15:46):And it's done! 0.52.0 is now published and live.
Andrew Brown (Dec 18 2019 at 17:23):I marked the PR bringing 0.52.0 into wasmtime as ready for review if anyone has time: https://github.com/bytecodealliance/wasmtime/pull/710
Sean Stangl (Dec 18 2019 at 17:25):Oh, into wasmtime, that's not my territory. I just saw "Andrew Brown" and jumped :)
Andrew Brown (Dec 18 2019 at 17:30):@Sean Stangl there's an easy one for and_not in cranelift coming your way!
Dan Gohman (Dec 18 2019 at 21:23):Unclear why the tests fail on beta :-(
Last updated: Nov 22 2024 at 17:03 UTC