fitzgen (he/him) (Mar 10 2020 at 23:01): fitzgen (he/him) (Mar 10 2020 at 23:01):After the repo merge, some folks have been swamped in github emails for wasmtime things, when they only want to keep an eye on cranelift things. Well, now you can do that!
We now automatically label pull requests that touch cranelift/* files with the "cranelift" label. See https://github.com/bytecodealliance/wasmtime/blob/master/.github/labeler.yml for more paths that get automatically labeled, and feel free to add new ones!
You can opt into getting @'d by a bot whenever a pull request or issue is labeled with a label that you care about. Add your username and list of labels you want to subscribe to here: https://github.com/bytecodealliance/wasmtime/blob/master/.github/subscribe-to-label.json
The one gap is that this doesn't cover triaging new issues that didn't use an issue template (which automatically apply labels). I think you'll have to lean on those of us who are watching the full repo to triage and label new issues correctly.
fitzgen (he/him) (Mar 11 2020 at 17:27):quick update:
it looks like the subscribe-to-label action is working: https://github.com/bytecodealliance/wasmtime/issues/1220#issuecomment-597763152
however, it looks like the automatic labeler action is not working. for example, I would have expected this pull request to automatically have been labeled "fuzzing" but it wasn't: https://github.com/bytecodealliance/wasmtime/pull/1277
I'll look into this some more and see if I can figure out what's going on. stay tuned for updates.
Pat Hickey (Mar 11 2020 at 17:44):thank you for your work on this!
fitzgen (he/him) (Mar 11 2020 at 18:11):I overlooked this in the README of the labeler action:
Note that only pull requests being opened from the same repository can be labeled. This action will not currently work for pull requests from forks -- like is common in open source projects -- because the token for forked pull request workflows does not have write permissions.
D'oh.
There is an open PR that makes the labeler run on a cron schedule, rather than on pull requests, and it should have the base repo's permissions when run then. I'll look into forking the labeler action and rebasing that PR onto our fork.
fitzgen (he/him) (Mar 11 2020 at 19:57):Looks like we need to also run the subscribe-to-label action on a cron schedule for pull requests (as opposed to when a label is added to an issue): https://github.com/bytecodealliance/wasmtime/pull/1290/checks?check_run_id=501503929#step:2:25
fitzgen (he/him) (Mar 11 2020 at 21:03):Okay the labeler is working now: https://github.com/bytecodealliance/wasmtime/pull/920#event-3120495952
Still working on a cron schedule mode for the subscribe-to-label action
Alex Crichton (Mar 11 2020 at 21:56):@fitzgen (he/him) looks like it works! - https://github.com/bytecodealliance/wasmtime/pull/1294#event-3120631746
fitzgen (he/him) (Mar 11 2020 at 21:57):yeah, the automatic labeler works, the @-notifier for label subscriptions is still a WIP
fitzgen (he/him) (Mar 11 2020 at 21:57):(the @-notifier is a WIP for PRs; it works for issues already)
Alex Crichton (Mar 12 2020 at 17:06):@fitzgen (he/him) you may be interested in this failure -- https://github.com/bytecodealliance/wasmtime/runs/503783076?check_suite_focus=true
fitzgen (he/him) (Mar 12 2020 at 17:07):yeah, I'm debugging now
github actions are very fun where you push and see what happens and then wait 5 minutes for the next run to find the next bug...
Alex Crichton (Mar 12 2020 at 17:18):@fitzgen (he/him) er I assume you see the torrent of notifications?
Alex Crichton (Mar 12 2020 at 17:18):https://github.com/bytecodealliance/wasmtime/pull/1013#issuecomment-598306884 e.g.
fitzgen (he/him) (Mar 12 2020 at 17:19):oh god... I didn't see the comments
I'll disable temporarily
fitzgen (he/him) (Mar 12 2020 at 17:22):https://github.com/bytecodealliance/wasmtime/pull/1300
fitzgen (he/him) (Mar 12 2020 at 18:12):ok I think I fixed the bot: https://github.com/fitzgen/wasmtime/pull/2#issuecomment-598342193
going to wait to re-enable on bytecodealliance/wasmtime until I verify that it isn't making duplicate comments next time it is scheduled
Pat Hickey (Mar 12 2020 at 18:15):just curious, where did the quoting every letter bug come from? ive made that bug in a bunch of different programming languages but never before in javascript :)
fitzgen (he/him) (Mar 12 2020 at 18:16):I did new Set(...arrayOfLabels) when I should have done new Set(arrayOfLabels) :-/
Pat Hickey (Mar 12 2020 at 18:17):right on. its a super easy bug to make
fitzgen (he/him) (Mar 12 2020 at 18:17):typescript would have caught this, maybe I should be using that
fitzgen (he/him) (Mar 12 2020 at 19:55):ok, I've fixed the bot! it now parses labels correctly and understands when it has already left a comment notifying folks about a certain label subscription.
going to re-enable it now
Last updated: Dec 23 2024 at 13:07 UTC