CI build failure due to zstd crate? · cranelift

Stream: cranelift

Topic: CI build failure due to zstd crate?

Chris Fallin (Jun 03 2020 at 16:31):

I saw this in a failed CI run just now:

    Compiling zstd v0.5.2+zstd.1.4.5
error: use of deprecated item 'region::protect::Protection::ReadWrite': Use Protection::READ_WRITE instead
   --> crates/runtime/src/mmap.rs:185:55
    |
185 |         unsafe { region::protect(ptr.add(start), len, region::Protection::ReadWrite) }
    |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-D deprecated` implied by `-D warnings`

error: aborting due to previous error

I'm not sure whether the crate was recently updated, or our toolchain, or our flags (equiv of -Werror?), or something else -- is anyone else seeing this?

Chris Fallin (Jun 03 2020 at 16:33):

Oh, nevermind, I need more coffee. zstd is unrelated. +1 for parallel builds.

Chris Fallin (Jun 03 2020 at 16:36):

Someone review https://github.com/bytecodealliance/wasmtime/pull/1811? @Alex Crichton or @Benjamin Bouvier perhaps?

Fix build warnings (errors on CI) due to mmap flag rename and deprecation. by cfallin · Pull Request #1811 · bytecodealliance/wasmtime

Should fix recent build failures on CI.

Benjamin Bouvier (Jun 03 2020 at 16:36):

Done!

Alex Crichton (Jun 03 2020 at 16:38):

@Chris Fallin FYI there's a similar PR at https://github.com/bytecodealliance/wasmtime/pull/1807 but it looks like some tests may also need an update?

Fix warning by sunfishcode · Pull Request #1807 · bytecodealliance/wasmtime

The Wasmtime publishing scripts run cargo update, which upgraded Wasmtime's region dependency from 2.1.0 to 2.2.0. In 2.2.0, region deprecated region::Protection::ReadExecute and added region::...

Chris Fallin (Jun 03 2020 at 16:46):

D'oh, I missed the duplicate. Looks like Dan's PR is a few hours old and he may not be around right now though? I can fix the tests and go ahead with this one

Last updated: Dec 23 2024 at 13:07 UTC