Stream: cranelift

Topic: ✔ Add LibCall::Memcmp (PR #2953)

view this post on Zulip scottmcm (Nov 29 2021 at 21:51):

Hi folks!

I submitted https://github.com/bytecodealliance/wasmtime/pull/2953 back in May.

The comment on LibCall says it's "likely to grow" and memcmp's been in libc since C89, so I was hoping that adding it following the precedent of the existing Memcpy/Memset/Memmove variants would be non-controversial.

What's the process to have someone look at it and either accept, reject, or request changes? I've rebased it and it's passing all the tests.

Cranelift: Add `LibCall::Memcmp` by scottmcm · Pull Request #2953 · bytecodealliance/wasmtime
This adds LibCall::Memcmp and a corresponding FunctionBuilder::call_memcmp, following the existing patterns of memcpy, memset, & memmove. The comment says the enum is "likely to grow&quot...

view this post on Zulip Chris Fallin (Nov 29 2021 at 21:57):

@scottmcm , I'm happy to take a look -- thanks for the PR!

view this post on Zulip Chris Fallin (Nov 29 2021 at 21:58):

(to answer your underlying question, there's not much process beyond "whoever happens to see the PR", but feel free to ping as you have here if no one picks something up!)

view this post on Zulip scottmcm (Nov 30 2021 at 02:52):

Thanks, Chris!

view this post on Zulip Notification Bot (Nov 30 2021 at 02:52):

scottmcm has marked this topic as resolved.

Last updated: Oct 23 2024 at 20:03 UTC